You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "AngersZhuuuu (via GitHub)" <gi...@apache.org> on 2023/02/03 10:30:33 UTC

[GitHub] [incubator-celeborn] AngersZhuuuu opened a new pull request, #1203: [CELEBORN-269][BUG] Disable replication throw NPE when removeBatch inpushDtaHandler

AngersZhuuuu opened a new pull request, #1203:
URL: https://github.com/apache/incubator-celeborn/pull/1203

   ### What changes were proposed in this pull request?
   ![image](https://user-images.githubusercontent.com/46485123/216577893-d91f364c-34f5-44e4-9ea5-88a907b6d234.png)
   
   
   
   ### Why are the changes needed?
   
   
   
   ### Does this PR introduce _any_ user-facing change?
   
   
   
   ### How was this patch tested?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1203: [CELEBORN-269][BUG] Disable replication throw NPE when removeBatch inpushDtaHandler

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1203:
URL: https://github.com/apache/incubator-celeborn/pull/1203#issuecomment-1415685815

   # [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1203?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1203](https://codecov.io/gh/apache/incubator-celeborn/pull/1203?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7430594) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/ff683ffc919aff2c13ca97806c8f78dbf9afb6d0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ff683ff) will **decrease** coverage by `0.03%`.
   > The diff coverage is `0.00%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##               main    #1203      +/-   ##
   ============================================
   - Coverage     26.44%   26.40%   -0.03%     
   + Complexity      760      756       -4     
   ============================================
     Files           206      206              
     Lines         17596    17598       +2     
     Branches       1921     1923       +2     
   ============================================
   - Hits           4651     4645       -6     
   - Misses        12630    12634       +4     
   - Partials        315      319       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-celeborn/pull/1203?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...leborn/service/deploy/worker/PushDataHandler.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1203?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d29ya2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vc2VydmljZS9kZXBsb3kvd29ya2VyL1B1c2hEYXRhSGFuZGxlci5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
   | [...celeborn/service/deploy/master/SlotsAllocator.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1203?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9zZXJ2aWNlL2RlcGxveS9tYXN0ZXIvU2xvdHNBbGxvY2F0b3IuamF2YQ==) | `69.27% <0.00%> (-2.45%)` | :arrow_down: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] AngersZhuuuu commented on pull request #1203: [CELEBORN-269][BUG] Disable replication throw NPE when removeBatch inpushDtaHandler

Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on PR #1203:
URL: https://github.com/apache/incubator-celeborn/pull/1203#issuecomment-1415667310

   ping @waitinfuture 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] waitinfuture merged pull request #1203: [CELEBORN-269][BUG] Disable replication throw NPE when removeBatch in pushDataHandler

Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture merged PR #1203:
URL: https://github.com/apache/incubator-celeborn/pull/1203


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org