[GitHub] spark pull request #18971: [SPARK-21764][TESTS] Fix tests failures on Window...

[HyukjinKwon <gi...@git.apache.org>]

Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18971#discussion_r133853212
  
    --- Diff: core/src/test/scala/org/apache/spark/scheduler/ReplayListenerSuite.scala ---
    @@ -151,7 +153,10 @@ class ReplayListenerSuite extends SparkFunSuite with BeforeAndAfter with LocalSp
        * assumption that the event logging behavior is correct (tested in a separate suite).
        */
       private def testApplicationReplay(codecName: Option[String] = None) {
    -    val logDirPath = Utils.getFilePath(testDir, "test-replay")
    +    val logDir = new File(testDir.getAbsolutePath, "test-replay")
    +    // Here, it creates `Path` from the URI instead of the absolute path for the explicit file
    +    // scheme so that the string representation of this `Path` has leading file scheme correctly.
    +    val logDirPath = new Path(logDir.toURI)
    --- End diff --
    
    cc @vanzin, I believe I need your look. Could you take a look when you have some time?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org