You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metamodel.apache.org by arjansh <gi...@git.apache.org> on 2016/08/16 10:48:02 UTC
[GitHub] metamodel pull request #125: Use ColumnNamingStrategy argument in CsvConfigu...
GitHub user arjansh opened a pull request:
https://github.com/apache/metamodel/pull/125
Use ColumnNamingStrategy argument in CsvConfiguration constructor
Fixes METAMODEL-1113.
Added unit tests to the different types of datastores which can make use of the ColumnNamingStrategies mechanism and fixed the CsvConfiguration constructor which takes a ColumnNamingStrategy as an arguments but doesn't assign it to its columnNamingStrategy field.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arjansh/metamodel METAMODEL-1113-csv-datastore-column-naming
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metamodel/pull/125.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #125
----
commit 7d759772bf2d41e0d2f0fb103f163601e4f2ba04
Author: Arjan Seijkens <ar...@humaninference.com>
Date: 2016-08-16T10:46:01Z
Fixes METAMODEL-1113.
Added unit tests to the different types of datastores which can make use of the ColumnNamingStrategies mechanism and fixed the CsvConfiguration constructor which takes a ColumnNamingStrategy as an arguments but doesn't assign it to its columnNamingStrategy field.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel issue #125: Use ColumnNamingStrategy argument in CsvConfiguration ...
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/125
LGTM!
(ouch what a lame bug - I feel a bit silly for probably being the one who introduced it)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request #125: Use ColumnNamingStrategy argument in CsvConfigu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metamodel/pull/125
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---