You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2019/07/12 08:04:36 UTC
Re: Review Request 70844: Implemented `cleanup` method of the
`namespaces/ipc` isolator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70844/#review216549
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp
Lines 397-398 (patched)
<https://reviews.apache.org/r/70844/#comment303763>
I would add containerID and the dir.
- Gilbert Song
On June 12, 2019, 7:36 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70844/
> -----------------------------------------------------------
>
> (Updated June 12, 2019, 7:36 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Bugs: MESOS-9788
> https://issues.apache.org/jira/browse/MESOS-9788
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented `cleanup` method of the `namespaces/ipc` isolator.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/namespaces/ipc.hpp 32c888309ca536d944e4d73641aed214805ccce2
> src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp 6c8e8eed69ed355094f7d9b54bde25a8a9bc63f7
>
>
> Diff: https://reviews.apache.org/r/70844/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>