You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/03/17 12:29:41 UTC

[GitHub] [skywalking] Shikugawa opened a new issue #6571: SkyWalking version reporter through CDS

Shikugawa opened a new issue #6571:
URL: https://github.com/apache/skywalking/issues/6571


   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [ ] Question or discussion
   - [ ] Bug
   - [x] Requirement
   - [ ] Feature or performance improvement
   
   ### Requirement or improvement
   
   I think that CDS feature can be utilized reporting OAP version to agent. It can be required to switch version-specific behavior on the agent. WDYT?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #6571: SkyWalking OAP version reporter through CDS

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6571:
URL: https://github.com/apache/skywalking/issues/6571#issuecomment-801130359


   I am going to close this discussion for now. Let's see whether there is a new case.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #6571: SkyWalking OAP version reporter through CDS

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6571:
URL: https://github.com/apache/skywalking/issues/6571#issuecomment-801047666


   Report OAP agent? Could you provide a little more details about how it helps? And how the agent will use it if there is a version.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #6571: SkyWalking OAP version reporter through CDS

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6571:
URL: https://github.com/apache/skywalking/issues/6571#issuecomment-801057535


   > @wu-sheng This is just my consideration based on imagination. If we have a breaking endpoint change of data collect protocol, an agent will want to switch them. Do we have these situations?
   
   2 background stories are, SkyWalking as a tracer server, our ecosystem is set up very slowly. So, the protocol is nearly never changed. v3(we are using) is set up in 2020, v2 was in 2017.
   Even, we need to change something, we expect to add a new field, rather than a break.
   At last, we have to, we will change service name(v2->v3), or like you asked us to add `v3` in the namespace. So you could check GRPC's `unimplemented service` error.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng closed issue #6571: SkyWalking OAP version reporter through CDS

Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #6571:
URL: https://github.com/apache/skywalking/issues/6571


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] Shikugawa commented on issue #6571: SkyWalking OAP version reporter through CDS

Posted by GitBox <gi...@apache.org>.
Shikugawa commented on issue #6571:
URL: https://github.com/apache/skywalking/issues/6571#issuecomment-801073436


   Sure. maybe we don't have this right now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] Shikugawa commented on issue #6571: SkyWalking OAP version reporter through CDS

Posted by GitBox <gi...@apache.org>.
Shikugawa commented on issue #6571:
URL: https://github.com/apache/skywalking/issues/6571#issuecomment-801052874


   @wu-sheng This is just my consideration based on imagination. If we have a breaking endpoint change of data collect protocol, an agent will want to switch them. Do we have these situations?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org