You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by ap...@apache.org on 2013/11/14 02:00:11 UTC

svn commit: r1541772 - in /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase: CellUtil.java Tag.java

Author: apurtell
Date: Thu Nov 14 01:00:10 2013
New Revision: 1541772

URL: http://svn.apache.org/r1541772
Log:
HBASE-9962. Improve tag iteration

Modified:
    hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java
    hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/Tag.java

Modified: hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java
URL: http://svn.apache.org/viewvc/hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java?rev=1541772&r1=1541771&r2=1541772&view=diff
==============================================================================
--- hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java (original)
+++ hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java Thu Nov 14 01:00:10 2013
@@ -380,14 +380,14 @@ public final class CellUtil {
   
   /********************* tags *************************************/
   /**
-   * Util method to iterate through the tags. Used in testcase
+   * Util method to iterate through the tags
    * 
    * @param tags
    * @param offset
    * @param length
    * @return iterator for the tags
    */
-  public static Iterator<Tag> tagsIterator(final byte[] tags, final int offset, final short length) {
+  public static Iterator<Tag> tagsIterator(final byte[] tags, final int offset, final int length) {
     return new Iterator<Tag>() {
       private int pos = offset;
       private int endOffset = offset + length - 1;

Modified: hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/Tag.java
URL: http://svn.apache.org/viewvc/hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/Tag.java?rev=1541772&r1=1541771&r2=1541772&view=diff
==============================================================================
--- hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/Tag.java (original)
+++ hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/Tag.java Thu Nov 14 01:00:10 2013
@@ -119,14 +119,14 @@ public class Tag {
   /**
    * @return Length of actual tag bytes within the backed buffer
    */
-  int getTagLength() {
+  public int getTagLength() {
     return this.length - INFRASTRUCTURE_SIZE;
   }
 
   /**
    * @return Offset of actual tag bytes within the backed buffer
    */
-  int getTagOffset() {
+  public int getTagOffset() {
     return this.offset + INFRASTRUCTURE_SIZE;
   }
 
@@ -145,7 +145,7 @@ public class Tag {
    * @param length
    * @return List of tags
    */
-  public static List<Tag> asList(byte[] b, int offset, short length) {
+  public static List<Tag> asList(byte[] b, int offset, int length) {
     List<Tag> tags = new ArrayList<Tag>();
     int pos = offset;
     while (pos < offset + length) {