You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/04/24 21:07:08 UTC

[GitHub] [incubator-superset] john-bodley opened a new pull request #7374: [fix] Fixing SQL parsing issue

john-bodley opened a new pull request #7374: [fix] Fixing SQL parsing issue
URL: https://github.com/apache/incubator-superset/pull/7374
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   
   This PR fixes an issue with parsing SQL where iterating over the identifiers associated with a `sqlparser` `IdentifierList` yields a `Token` (as opposed to a `TokenList`) resulting in the following error:
   ```
   builtins:AttributeError: 'Token' object has no attribute 'tokens'
   ```
   
   ### TEST PLAN
   
   CI. 
   
   ### REVIEWERS
   
   to: @michellethomas @mistercrunch 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org