You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jean-Daniel Cryans (Created) (JIRA)" <ji...@apache.org> on 2012/04/03 20:58:25 UTC
[jira] [Created] (HBASE-5706) "Dropping fs latency stats since
buffer is full" spam
"Dropping fs latency stats since buffer is full" spam
-----------------------------------------------------
Key: HBASE-5706
URL: https://issues.apache.org/jira/browse/HBASE-5706
Project: HBase
Issue Type: Improvement
Reporter: Jean-Daniel Cryans
Priority: Minor
Fix For: 0.94.0, 0.96.0
I see tons of this while running tests (note that it's a WARN):
{noformat}
2012-04-03 18:54:47,172 WARN org.apache.hadoop.hbase.io.hfile.HFile: Dropping fs latency stats since buffer is full
{noformat}
While the code says this:
{noformat}
// we don't want to fill up the logs with this message, so only log it
// once every 30 seconds at most
// I also want to avoid locks on the 'critical path' (the common case will be
// uncontended) - hence the CAS
private static void logDroppedLatencyStat() {
{noformat}
It doesn't seem like this message is actionnable and even though it's printed "only" every 30 seconds it's still very spammy.
We should get rid of it or make it more useful (I don't know which).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Created] (HBASE-5706) "Dropping fs latency stats since buffer is full" spam
Posted by Andrew Purtell <ap...@apache.org>.
Best regards,
- Andy
Problems worthy of attack prove their worth by hitting back. - Piet Hein (via Tom White)
>________________________________
> From: Jean-Daniel Cryans (Created) (JIRA) <ji...@apache.org>
>To: issues@hbase.apache.org
>Sent: Tuesday, April 3, 2012 11:58 AM
>Subject: [jira] [Created] (HBASE-5706) "Dropping fs latency stats since buffer is full" spam
>
>"Dropping fs latency stats since buffer is full" spam
>-----------------------------------------------------
>
> Key: HBASE-5706
> URL: https://issues.apache.org/jira/browse/HBASE-5706
> Project: HBase
> Issue Type: Improvement
> Reporter: Jean-Daniel Cryans
> Priority: Minor
> Fix For: 0.94.0, 0.96.0
>
>
>I see tons of this while running tests (note that it's a WARN):
>
>{noformat}
>2012-04-03 18:54:47,172 WARN org.apache.hadoop.hbase.io.hfile.HFile: Dropping fs latency stats since buffer is full
>{noformat}
>
>While the code says this:
>
>{noformat}
> // we don't want to fill up the logs with this message, so only log it
> // once every 30 seconds at most
> // I also want to avoid locks on the 'critical path' (the common case will be
> // uncontended) - hence the CAS
> private static void logDroppedLatencyStat() {
>{noformat}
>
>It doesn't seem like this message is actionnable and even though it's printed "only" every 30 seconds it's still very spammy.
>
>We should get rid of it or make it more useful (I don't know which).
>
>--
>This message is automatically generated by JIRA.
>If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
>For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>
>
>
[jira] [Assigned] (HBASE-5706) "Dropping fs latency stats since
buffer is full" spam
Posted by "stack (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack reassigned HBASE-5706:
----------------------------
Assignee: Shaneal Manek
> "Dropping fs latency stats since buffer is full" spam
> -----------------------------------------------------
>
> Key: HBASE-5706
> URL: https://issues.apache.org/jira/browse/HBASE-5706
> Project: HBase
> Issue Type: Improvement
> Reporter: Jean-Daniel Cryans
> Assignee: Shaneal Manek
> Priority: Minor
> Fix For: 0.94.0, 0.96.0
>
>
> I see tons of this while running tests (note that it's a WARN):
> {noformat}
> 2012-04-03 18:54:47,172 WARN org.apache.hadoop.hbase.io.hfile.HFile: Dropping fs latency stats since buffer is full
> {noformat}
> While the code says this:
> {noformat}
> // we don't want to fill up the logs with this message, so only log it
> // once every 30 seconds at most
> // I also want to avoid locks on the 'critical path' (the common case will be
> // uncontended) - hence the CAS
> private static void logDroppedLatencyStat() {
> {noformat}
> It doesn't seem like this message is actionnable and even though it's printed "only" every 30 seconds it's still very spammy.
> We should get rid of it or make it more useful (I don't know which).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5706) "Dropping fs latency stats since
buffer is full" spam
Posted by "Shaneal Manek (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shaneal Manek updated HBASE-5706:
---------------------------------
Attachment: HBASE-5706.patch
> "Dropping fs latency stats since buffer is full" spam
> -----------------------------------------------------
>
> Key: HBASE-5706
> URL: https://issues.apache.org/jira/browse/HBASE-5706
> Project: HBase
> Issue Type: Improvement
> Reporter: Jean-Daniel Cryans
> Assignee: Shaneal Manek
> Priority: Minor
> Fix For: 0.94.0, 0.96.0
>
> Attachments: HBASE-5706.patch
>
>
> I see tons of this while running tests (note that it's a WARN):
> {noformat}
> 2012-04-03 18:54:47,172 WARN org.apache.hadoop.hbase.io.hfile.HFile: Dropping fs latency stats since buffer is full
> {noformat}
> While the code says this:
> {noformat}
> // we don't want to fill up the logs with this message, so only log it
> // once every 30 seconds at most
> // I also want to avoid locks on the 'critical path' (the common case will be
> // uncontended) - hence the CAS
> private static void logDroppedLatencyStat() {
> {noformat}
> It doesn't seem like this message is actionnable and even though it's printed "only" every 30 seconds it's still very spammy.
> We should get rid of it or make it more useful (I don't know which).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5706) "Dropping fs latency stats since
buffer is full" spam
Posted by "Shaneal Manek (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245950#comment-13245950 ]
Shaneal Manek commented on HBASE-5706:
--------------------------------------
On consideration, I think JD and Andrew are right. It's relatively expensive to log (although we're talking less than a micro of overhead per PUT near as I can tell) and, more importantly, not at all actionable. We could make the queue size tweakable via configs, but I don't think that's something users should have to care about.
So let's just get rid of it. I've attached a patch that seems to apply cleanly to 0.94/0.96/trunk.
Thanks for pointing it out! I think I'm just used to working on smaller projects where the original devs are the only ones who will ever see the system logs ;-) I'm personally interested in that log message out of idle curiosity, but users of HBase do not (and should not) care.
> "Dropping fs latency stats since buffer is full" spam
> -----------------------------------------------------
>
> Key: HBASE-5706
> URL: https://issues.apache.org/jira/browse/HBASE-5706
> Project: HBase
> Issue Type: Improvement
> Reporter: Jean-Daniel Cryans
> Assignee: Shaneal Manek
> Priority: Minor
> Fix For: 0.94.0, 0.96.0
>
>
> I see tons of this while running tests (note that it's a WARN):
> {noformat}
> 2012-04-03 18:54:47,172 WARN org.apache.hadoop.hbase.io.hfile.HFile: Dropping fs latency stats since buffer is full
> {noformat}
> While the code says this:
> {noformat}
> // we don't want to fill up the logs with this message, so only log it
> // once every 30 seconds at most
> // I also want to avoid locks on the 'critical path' (the common case will be
> // uncontended) - hence the CAS
> private static void logDroppedLatencyStat() {
> {noformat}
> It doesn't seem like this message is actionnable and even though it's printed "only" every 30 seconds it's still very spammy.
> We should get rid of it or make it more useful (I don't know which).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5706) "Dropping fs latency stats since
buffer is full" spam
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245692#comment-13245692 ]
stack commented on HBASE-5706:
------------------------------
Assigning Shaneal so he'll at least take a look at it. Make a recommendation boss and one of us can fix it. Good on you.
> "Dropping fs latency stats since buffer is full" spam
> -----------------------------------------------------
>
> Key: HBASE-5706
> URL: https://issues.apache.org/jira/browse/HBASE-5706
> Project: HBase
> Issue Type: Improvement
> Reporter: Jean-Daniel Cryans
> Assignee: Shaneal Manek
> Priority: Minor
> Fix For: 0.94.0, 0.96.0
>
>
> I see tons of this while running tests (note that it's a WARN):
> {noformat}
> 2012-04-03 18:54:47,172 WARN org.apache.hadoop.hbase.io.hfile.HFile: Dropping fs latency stats since buffer is full
> {noformat}
> While the code says this:
> {noformat}
> // we don't want to fill up the logs with this message, so only log it
> // once every 30 seconds at most
> // I also want to avoid locks on the 'critical path' (the common case will be
> // uncontended) - hence the CAS
> private static void logDroppedLatencyStat() {
> {noformat}
> It doesn't seem like this message is actionnable and even though it's printed "only" every 30 seconds it's still very spammy.
> We should get rid of it or make it more useful (I don't know which).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5706) "Dropping fs latency stats since
buffer is full" spam
Posted by "Andrew Purtell (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245775#comment-13245775 ]
Andrew Purtell commented on HBASE-5706:
---------------------------------------
Best regards,
- Andy
Problems worthy of attack prove their worth by hitting back. - Piet Hein (via Tom White)
> "Dropping fs latency stats since buffer is full" spam
> -----------------------------------------------------
>
> Key: HBASE-5706
> URL: https://issues.apache.org/jira/browse/HBASE-5706
> Project: HBase
> Issue Type: Improvement
> Reporter: Jean-Daniel Cryans
> Assignee: Shaneal Manek
> Priority: Minor
> Fix For: 0.94.0, 0.96.0
>
>
> I see tons of this while running tests (note that it's a WARN):
> {noformat}
> 2012-04-03 18:54:47,172 WARN org.apache.hadoop.hbase.io.hfile.HFile: Dropping fs latency stats since buffer is full
> {noformat}
> While the code says this:
> {noformat}
> // we don't want to fill up the logs with this message, so only log it
> // once every 30 seconds at most
> // I also want to avoid locks on the 'critical path' (the common case will be
> // uncontended) - hence the CAS
> private static void logDroppedLatencyStat() {
> {noformat}
> It doesn't seem like this message is actionnable and even though it's printed "only" every 30 seconds it's still very spammy.
> We should get rid of it or make it more useful (I don't know which).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5706) "Dropping fs latency stats since
buffer is full" spam
Posted by "Andrew Purtell (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245770#comment-13245770 ]
Andrew Purtell commented on HBASE-5706:
---------------------------------------
Interesting, this came up today here too. I've been playing around with a slightly modified version of this patch. Under high load the FS latency stat buffers can fill up before the metrics thread drains them, doesn't seem an exceptional condition. Removing logDroppedLatencyStat() and logging around it gets rid of a number of branches and a CAS from a hot code path, so that's what we did.
> "Dropping fs latency stats since buffer is full" spam
> -----------------------------------------------------
>
> Key: HBASE-5706
> URL: https://issues.apache.org/jira/browse/HBASE-5706
> Project: HBase
> Issue Type: Improvement
> Reporter: Jean-Daniel Cryans
> Assignee: Shaneal Manek
> Priority: Minor
> Fix For: 0.94.0, 0.96.0
>
>
> I see tons of this while running tests (note that it's a WARN):
> {noformat}
> 2012-04-03 18:54:47,172 WARN org.apache.hadoop.hbase.io.hfile.HFile: Dropping fs latency stats since buffer is full
> {noformat}
> While the code says this:
> {noformat}
> // we don't want to fill up the logs with this message, so only log it
> // once every 30 seconds at most
> // I also want to avoid locks on the 'critical path' (the common case will be
> // uncontended) - hence the CAS
> private static void logDroppedLatencyStat() {
> {noformat}
> It doesn't seem like this message is actionnable and even though it's printed "only" every 30 seconds it's still very spammy.
> We should get rid of it or make it more useful (I don't know which).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5706) "Dropping fs latency stats since
buffer is full" spam
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247033#comment-13247033 ]
Hudson commented on HBASE-5706:
-------------------------------
Integrated in HBase-TRUNK-security #157 (See [https://builds.apache.org/job/HBase-TRUNK-security/157/])
HBASE-5706 'Dropping fs latency stats since buffer is full' spam (Revision 1309457)
Result = FAILURE
stack :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
> "Dropping fs latency stats since buffer is full" spam
> -----------------------------------------------------
>
> Key: HBASE-5706
> URL: https://issues.apache.org/jira/browse/HBASE-5706
> Project: HBase
> Issue Type: Improvement
> Reporter: Jean-Daniel Cryans
> Assignee: Shaneal Manek
> Priority: Minor
> Fix For: 0.94.0, 0.96.0
>
> Attachments: HBASE-5706.patch
>
>
> I see tons of this while running tests (note that it's a WARN):
> {noformat}
> 2012-04-03 18:54:47,172 WARN org.apache.hadoop.hbase.io.hfile.HFile: Dropping fs latency stats since buffer is full
> {noformat}
> While the code says this:
> {noformat}
> // we don't want to fill up the logs with this message, so only log it
> // once every 30 seconds at most
> // I also want to avoid locks on the 'critical path' (the common case will be
> // uncontended) - hence the CAS
> private static void logDroppedLatencyStat() {
> {noformat}
> It doesn't seem like this message is actionnable and even though it's printed "only" every 30 seconds it's still very spammy.
> We should get rid of it or make it more useful (I don't know which).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5706) "Dropping fs latency stats since
buffer is full" spam
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246444#comment-13246444 ]
Hudson commented on HBASE-5706:
-------------------------------
Integrated in HBase-TRUNK #2709 (See [https://builds.apache.org/job/HBase-TRUNK/2709/])
HBASE-5706 'Dropping fs latency stats since buffer is full' spam (Revision 1309457)
Result = FAILURE
stack :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
> "Dropping fs latency stats since buffer is full" spam
> -----------------------------------------------------
>
> Key: HBASE-5706
> URL: https://issues.apache.org/jira/browse/HBASE-5706
> Project: HBase
> Issue Type: Improvement
> Reporter: Jean-Daniel Cryans
> Assignee: Shaneal Manek
> Priority: Minor
> Fix For: 0.94.0, 0.96.0
>
> Attachments: HBASE-5706.patch
>
>
> I see tons of this while running tests (note that it's a WARN):
> {noformat}
> 2012-04-03 18:54:47,172 WARN org.apache.hadoop.hbase.io.hfile.HFile: Dropping fs latency stats since buffer is full
> {noformat}
> While the code says this:
> {noformat}
> // we don't want to fill up the logs with this message, so only log it
> // once every 30 seconds at most
> // I also want to avoid locks on the 'critical path' (the common case will be
> // uncontended) - hence the CAS
> private static void logDroppedLatencyStat() {
> {noformat}
> It doesn't seem like this message is actionnable and even though it's printed "only" every 30 seconds it's still very spammy.
> We should get rid of it or make it more useful (I don't know which).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5706) "Dropping fs latency stats since
buffer is full" spam
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5706:
-------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed branch and trunk. Thanks for the patch Shaneal.
> "Dropping fs latency stats since buffer is full" spam
> -----------------------------------------------------
>
> Key: HBASE-5706
> URL: https://issues.apache.org/jira/browse/HBASE-5706
> Project: HBase
> Issue Type: Improvement
> Reporter: Jean-Daniel Cryans
> Assignee: Shaneal Manek
> Priority: Minor
> Fix For: 0.94.0, 0.96.0
>
> Attachments: HBASE-5706.patch
>
>
> I see tons of this while running tests (note that it's a WARN):
> {noformat}
> 2012-04-03 18:54:47,172 WARN org.apache.hadoop.hbase.io.hfile.HFile: Dropping fs latency stats since buffer is full
> {noformat}
> While the code says this:
> {noformat}
> // we don't want to fill up the logs with this message, so only log it
> // once every 30 seconds at most
> // I also want to avoid locks on the 'critical path' (the common case will be
> // uncontended) - hence the CAS
> private static void logDroppedLatencyStat() {
> {noformat}
> It doesn't seem like this message is actionnable and even though it's printed "only" every 30 seconds it's still very spammy.
> We should get rid of it or make it more useful (I don't know which).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5706) "Dropping fs latency stats since
buffer is full" spam
Posted by "Andrew Purtell (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Purtell updated HBASE-5706:
----------------------------------
Comment: was deleted
(was:
Best regards,
- Andy
Problems worthy of attack prove their worth by hitting back. - Piet Hein (via Tom White)
)
> "Dropping fs latency stats since buffer is full" spam
> -----------------------------------------------------
>
> Key: HBASE-5706
> URL: https://issues.apache.org/jira/browse/HBASE-5706
> Project: HBase
> Issue Type: Improvement
> Reporter: Jean-Daniel Cryans
> Assignee: Shaneal Manek
> Priority: Minor
> Fix For: 0.94.0, 0.96.0
>
>
> I see tons of this while running tests (note that it's a WARN):
> {noformat}
> 2012-04-03 18:54:47,172 WARN org.apache.hadoop.hbase.io.hfile.HFile: Dropping fs latency stats since buffer is full
> {noformat}
> While the code says this:
> {noformat}
> // we don't want to fill up the logs with this message, so only log it
> // once every 30 seconds at most
> // I also want to avoid locks on the 'critical path' (the common case will be
> // uncontended) - hence the CAS
> private static void logDroppedLatencyStat() {
> {noformat}
> It doesn't seem like this message is actionnable and even though it's printed "only" every 30 seconds it's still very spammy.
> We should get rid of it or make it more useful (I don't know which).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5706) "Dropping fs latency stats since
buffer is full" spam
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246907#comment-13246907 ]
Hudson commented on HBASE-5706:
-------------------------------
Integrated in HBase-0.94-security #7 (See [https://builds.apache.org/job/HBase-0.94-security/7/])
HBASE-5706 'Dropping fs latency stats since buffer is full' spam (Revision 1309459)
Result = SUCCESS
stack :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
> "Dropping fs latency stats since buffer is full" spam
> -----------------------------------------------------
>
> Key: HBASE-5706
> URL: https://issues.apache.org/jira/browse/HBASE-5706
> Project: HBase
> Issue Type: Improvement
> Reporter: Jean-Daniel Cryans
> Assignee: Shaneal Manek
> Priority: Minor
> Fix For: 0.94.0, 0.96.0
>
> Attachments: HBASE-5706.patch
>
>
> I see tons of this while running tests (note that it's a WARN):
> {noformat}
> 2012-04-03 18:54:47,172 WARN org.apache.hadoop.hbase.io.hfile.HFile: Dropping fs latency stats since buffer is full
> {noformat}
> While the code says this:
> {noformat}
> // we don't want to fill up the logs with this message, so only log it
> // once every 30 seconds at most
> // I also want to avoid locks on the 'critical path' (the common case will be
> // uncontended) - hence the CAS
> private static void logDroppedLatencyStat() {
> {noformat}
> It doesn't seem like this message is actionnable and even though it's printed "only" every 30 seconds it's still very spammy.
> We should get rid of it or make it more useful (I don't know which).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5706) "Dropping fs latency stats since
buffer is full" spam
Posted by "Shaneal Manek (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shaneal Manek updated HBASE-5706:
---------------------------------
Status: Patch Available (was: Open)
Patch just removes the (rate limited) log message.
> "Dropping fs latency stats since buffer is full" spam
> -----------------------------------------------------
>
> Key: HBASE-5706
> URL: https://issues.apache.org/jira/browse/HBASE-5706
> Project: HBase
> Issue Type: Improvement
> Reporter: Jean-Daniel Cryans
> Assignee: Shaneal Manek
> Priority: Minor
> Fix For: 0.94.0, 0.96.0
>
> Attachments: HBASE-5706.patch
>
>
> I see tons of this while running tests (note that it's a WARN):
> {noformat}
> 2012-04-03 18:54:47,172 WARN org.apache.hadoop.hbase.io.hfile.HFile: Dropping fs latency stats since buffer is full
> {noformat}
> While the code says this:
> {noformat}
> // we don't want to fill up the logs with this message, so only log it
> // once every 30 seconds at most
> // I also want to avoid locks on the 'critical path' (the common case will be
> // uncontended) - hence the CAS
> private static void logDroppedLatencyStat() {
> {noformat}
> It doesn't seem like this message is actionnable and even though it's printed "only" every 30 seconds it's still very spammy.
> We should get rid of it or make it more useful (I don't know which).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5706) "Dropping fs latency stats since
buffer is full" spam
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246004#comment-13246004 ]
Hadoop QA commented on HBASE-5706:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12521260/HBASE-5706.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.mapreduce.TestMultithreadedTableMapper
org.apache.hadoop.hbase.mapreduce.TestImportTsv
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
org.apache.hadoop.hbase.mapreduce.TestTableMapReduce
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1383//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1383//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1383//console
This message is automatically generated.
> "Dropping fs latency stats since buffer is full" spam
> -----------------------------------------------------
>
> Key: HBASE-5706
> URL: https://issues.apache.org/jira/browse/HBASE-5706
> Project: HBase
> Issue Type: Improvement
> Reporter: Jean-Daniel Cryans
> Assignee: Shaneal Manek
> Priority: Minor
> Fix For: 0.94.0, 0.96.0
>
> Attachments: HBASE-5706.patch
>
>
> I see tons of this while running tests (note that it's a WARN):
> {noformat}
> 2012-04-03 18:54:47,172 WARN org.apache.hadoop.hbase.io.hfile.HFile: Dropping fs latency stats since buffer is full
> {noformat}
> While the code says this:
> {noformat}
> // we don't want to fill up the logs with this message, so only log it
> // once every 30 seconds at most
> // I also want to avoid locks on the 'critical path' (the common case will be
> // uncontended) - hence the CAS
> private static void logDroppedLatencyStat() {
> {noformat}
> It doesn't seem like this message is actionnable and even though it's printed "only" every 30 seconds it's still very spammy.
> We should get rid of it or make it more useful (I don't know which).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5706) "Dropping fs latency stats since
buffer is full" spam
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246459#comment-13246459 ]
Hudson commented on HBASE-5706:
-------------------------------
Integrated in HBase-0.94 #85 (See [https://builds.apache.org/job/HBase-0.94/85/])
HBASE-5706 'Dropping fs latency stats since buffer is full' spam (Revision 1309459)
Result = FAILURE
stack :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
> "Dropping fs latency stats since buffer is full" spam
> -----------------------------------------------------
>
> Key: HBASE-5706
> URL: https://issues.apache.org/jira/browse/HBASE-5706
> Project: HBase
> Issue Type: Improvement
> Reporter: Jean-Daniel Cryans
> Assignee: Shaneal Manek
> Priority: Minor
> Fix For: 0.94.0, 0.96.0
>
> Attachments: HBASE-5706.patch
>
>
> I see tons of this while running tests (note that it's a WARN):
> {noformat}
> 2012-04-03 18:54:47,172 WARN org.apache.hadoop.hbase.io.hfile.HFile: Dropping fs latency stats since buffer is full
> {noformat}
> While the code says this:
> {noformat}
> // we don't want to fill up the logs with this message, so only log it
> // once every 30 seconds at most
> // I also want to avoid locks on the 'critical path' (the common case will be
> // uncontended) - hence the CAS
> private static void logDroppedLatencyStat() {
> {noformat}
> It doesn't seem like this message is actionnable and even though it's printed "only" every 30 seconds it's still very spammy.
> We should get rid of it or make it more useful (I don't know which).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira