You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Mona Chitnis <ch...@yahoo-inc.com> on 2012/07/21 03:41:33 UTC
Review Request: Bulk Monitoring API - Consolidated view of jobs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6073/
-----------------------------------------------------------
Review request for oozie.
Description
-------
First draft of the implementation of Bulk Monitoring API - RESTful WS API to traverse through bulk of multiple Oozie job levels and find the actions/workflows based on multiple filtering criteria
This is WIP
- refining API
- testing to see results
Uploading the patch to give a flavor of the implementation following design reviews
This addresses bug OOZIE-848.
https://issues.apache.org/jira/browse/OOZIE-848
Diffs
-----
trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1359926
trunk/client/src/main/java/org/apache/oozie/client/BulkResponseJob.java PRE-CREATION
trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1359926
trunk/client/src/main/java/org/apache/oozie/client/rest/JsonTags.java 1359926
trunk/client/src/main/java/org/apache/oozie/client/rest/JsonToBean.java 1359926
trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1359926
trunk/core/src/main/java/org/apache/oozie/BaseEngine.java 1359926
trunk/core/src/main/java/org/apache/oozie/client/rest/JsonBulkResponse.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/command/BulkJobsXCommand.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkJPAExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/servlet/V1JobsServlet.java 1359926
Diff: https://reviews.apache.org/r/6073/diff/
Testing
-------
not yet
Thanks,
Mona Chitnis
Re: Review Request: Bulk Monitoring API - Consolidated view of jobs
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6073/#review9343
-----------------------------------------------------------
trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java
<https://reviews.apache.org/r/6073/#comment20061>
Include information related to how to use the bulk command; which are the possible options
Also the twiki needs to be updated.
trunk/core/src/main/java/org/apache/oozie/BaseEngine.java
<https://reviews.apache.org/r/6073/#comment20062>
Shouldn't this method be in BundleEngine as the information is related to bundle job and its children
trunk/core/src/main/java/org/apache/oozie/BaseEngine.java
<https://reviews.apache.org/r/6073/#comment20063>
If you do a continue here, how will the start time and end time key-value pair be stored in the map?
trunk/core/src/main/java/org/apache/oozie/BaseEngine.java
<https://reviews.apache.org/r/6073/#comment20064>
The case when joblevel is not equal to "coordinatoraction" should also be handled
trunk/core/src/main/java/org/apache/oozie/BaseEngine.java
<https://reviews.apache.org/r/6073/#comment20065>
the comment doesn't hold as coord/bundle names are not being added or did you mean this comment as TODO item?
trunk/core/src/main/java/org/apache/oozie/client/rest/JsonBulkResponse.java
<https://reviews.apache.org/r/6073/#comment20066>
If I understand correctly, this class is a bean to json converter. What is the requirement for this on client side?
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkJPAExecutor.java
<https://reviews.apache.org/r/6073/#comment20071>
I dont see the bulkresponsebean class.
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkJPAExecutor.java
<https://reviews.apache.org/r/6073/#comment20072>
I dont see bulkresponseinfo too
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkJPAExecutor.java
<https://reviews.apache.org/r/6073/#comment20067>
this is not a join query
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkJPAExecutor.java
<https://reviews.apache.org/r/6073/#comment20068>
I dont see the join happening between coordinator job and coordinator action.. Am i missing something?
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkJPAExecutor.java
<https://reviews.apache.org/r/6073/#comment20069>
If the user doesn't specify any coordinator, shouldn't we get the list of all coordinators for the specified bundle. If yes, do we require a db query?
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkJPAExecutor.java
<https://reviews.apache.org/r/6073/#comment20070>
Shouldn't this be 'a' instead of 'w' ?
- Virag Kothari
On July 21, 2012, 1:41 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6073/
> -----------------------------------------------------------
>
> (Updated July 21, 2012, 1:41 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> First draft of the implementation of Bulk Monitoring API - RESTful WS API to traverse through bulk of multiple Oozie job levels and find the actions/workflows based on multiple filtering criteria
>
> This is WIP
> - refining API
> - testing to see results
>
> Uploading the patch to give a flavor of the implementation following design reviews
>
>
> This addresses bug OOZIE-848.
> https://issues.apache.org/jira/browse/OOZIE-848
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1359926
> trunk/client/src/main/java/org/apache/oozie/client/BulkResponseJob.java PRE-CREATION
> trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1359926
> trunk/client/src/main/java/org/apache/oozie/client/rest/JsonTags.java 1359926
> trunk/client/src/main/java/org/apache/oozie/client/rest/JsonToBean.java 1359926
> trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1359926
> trunk/core/src/main/java/org/apache/oozie/BaseEngine.java 1359926
> trunk/core/src/main/java/org/apache/oozie/client/rest/JsonBulkResponse.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/command/BulkJobsXCommand.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkJPAExecutor.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/servlet/V1JobsServlet.java 1359926
>
> Diff: https://reviews.apache.org/r/6073/diff/
>
>
> Testing
> -------
>
> not yet
>
>
> Thanks,
>
> Mona Chitnis
>
>