You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/10/24 17:15:58 UTC
[kudu-CR] [scripts] a tool to print out HybridTime timestamps
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14541
Change subject: [scripts] a tool to print out HybridTime timestamps
......................................................................
[scripts] a tool to print out HybridTime timestamps
This is Todd's script to output HybridTime timestamps in human-readable
form (works with Python2). The script reads from standard input until
EOF/EOS and outputs the result into standard output.
The script is useful when analyzing hybrid timestamps found in Kudu
WAL files. For example:
$ echo 6435399373400084500 | python convert-hybrid-timestamp.py
2019-10-15 05:27:05.146505 L=20
Change-Id: Ifc5b0d20c6f1bca0994d00a347ff14e4ae64a14c
---
A src/kudu/scripts/convert-hybrid-timestamp.py
1 file changed, 40 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/14541/1
--
To view, visit http://gerrit.cloudera.org:8080/14541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifc5b0d20c6f1bca0994d00a347ff14e4ae64a14c
Gerrit-Change-Number: 14541
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [scripts] a tool to print out HybridTime timestamps
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14541 )
Change subject: [scripts] a tool to print out HybridTime timestamps
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc5b0d20c6f1bca0994d00a347ff14e4ae64a14c
Gerrit-Change-Number: 14541
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Fri, 25 Oct 2019 23:24:19 +0000
Gerrit-HasComments: No
[kudu-CR] [scripts] a tool to print out HybridTime timestamps
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14541 )
Change subject: [scripts] a tool to print out HybridTime timestamps
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/14541/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14541/1//COMMIT_MSG@10
PS1, Line 10: (works with Python2)
> Support for python2 is ending soon, so it'd be worth making new scripts wor
Done
http://gerrit.cloudera.org:8080/#/c/14541/1/src/kudu/scripts/convert-hybrid-timestamp.py
File src/kudu/scripts/convert-hybrid-timestamp.py:
http://gerrit.cloudera.org:8080/#/c/14541/1/src/kudu/scripts/convert-hybrid-timestamp.py@40
PS1, Line 40: print
> This is problematic for python3. Can use print() function to be compatible
It's possible to use print() even without future import shenanigans, at least with python2.7
--
To view, visit http://gerrit.cloudera.org:8080/14541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc5b0d20c6f1bca0994d00a347ff14e4ae64a14c
Gerrit-Change-Number: 14541
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 24 Oct 2019 18:17:16 +0000
Gerrit-HasComments: Yes
[kudu-CR] [scripts] a tool to print out HybridTime timestamps
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins, Bankim Bhavsar,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14541
to look at the new patch set (#2).
Change subject: [scripts] a tool to print out HybridTime timestamps
......................................................................
[scripts] a tool to print out HybridTime timestamps
This is Todd's script to output HybridTime timestamps in human-readable
form (works with Python2 and Python3). The script reads from standard
input until EOF/EOS and outputs the result into standard output.
The script is useful when analyzing hybrid timestamps found in Kudu
WAL files. For example:
$ echo 6435399373400084500 | python convert-hybrid-timestamp.py
2019-10-15 05:27:05.146505 L=20
Change-Id: Ifc5b0d20c6f1bca0994d00a347ff14e4ae64a14c
---
A src/kudu/scripts/convert-hybrid-timestamp.py
1 file changed, 40 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/14541/2
--
To view, visit http://gerrit.cloudera.org:8080/14541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifc5b0d20c6f1bca0994d00a347ff14e4ae64a14c
Gerrit-Change-Number: 14541
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [scripts] a tool to print out HybridTime timestamps
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [scripts] a tool to print out HybridTime timestamps
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/14541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ifc5b0d20c6f1bca0994d00a347ff14e4ae64a14c
Gerrit-Change-Number: 14541
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [scripts] a tool to print out HybridTime timestamps
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14541 )
Change subject: [scripts] a tool to print out HybridTime timestamps
......................................................................
[scripts] a tool to print out HybridTime timestamps
This is Todd's script to output HybridTime timestamps in human-readable
form (works with Python2 and Python3). The script reads from standard
input until EOF/EOS and outputs the result into standard output.
The script is useful when analyzing hybrid timestamps found in Kudu
WAL files. For example:
$ echo 6435399373400084500 | python convert-hybrid-timestamp.py
2019-10-15 05:27:05.146505 L=20
Change-Id: Ifc5b0d20c6f1bca0994d00a347ff14e4ae64a14c
Reviewed-on: http://gerrit.cloudera.org:8080/14541
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Bankim Bhavsar <ba...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
A src/kudu/scripts/convert-hybrid-timestamp.py
1 file changed, 40 insertions(+), 0 deletions(-)
Approvals:
Alexey Serbin: Verified
Bankim Bhavsar: Looks good to me, but someone else must approve
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc5b0d20c6f1bca0994d00a347ff14e4ae64a14c
Gerrit-Change-Number: 14541
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
[kudu-CR] [scripts] a tool to print out HybridTime timestamps
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14541 )
Change subject: [scripts] a tool to print out HybridTime timestamps
......................................................................
Patch Set 2: Verified+1
Unrelated test failures, all of them have corresponding JIRA issues opened.
--
To view, visit http://gerrit.cloudera.org:8080/14541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc5b0d20c6f1bca0994d00a347ff14e4ae64a14c
Gerrit-Change-Number: 14541
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 24 Oct 2019 21:40:34 +0000
Gerrit-HasComments: No
[kudu-CR] [scripts] a tool to print out HybridTime timestamps
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14541 )
Change subject: [scripts] a tool to print out HybridTime timestamps
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/14541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc5b0d20c6f1bca0994d00a347ff14e4ae64a14c
Gerrit-Change-Number: 14541
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Fri, 25 Oct 2019 18:10:17 +0000
Gerrit-HasComments: No
[kudu-CR] [scripts] a tool to print out HybridTime timestamps
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14541 )
Change subject: [scripts] a tool to print out HybridTime timestamps
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/14541/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14541/1//COMMIT_MSG@10
PS1, Line 10: (works with Python2)
Support for python2 is ending soon, so it'd be worth making new scripts work with both.
http://gerrit.cloudera.org:8080/#/c/14541/1/src/kudu/scripts/convert-hybrid-timestamp.py
File src/kudu/scripts/convert-hybrid-timestamp.py:
http://gerrit.cloudera.org:8080/#/c/14541/1/src/kudu/scripts/convert-hybrid-timestamp.py@40
PS1, Line 40: print
This is problematic for python3. Can use print() function to be compatible with python2 and 3 by using following import.
`from __future__ import print_function`
--
To view, visit http://gerrit.cloudera.org:8080/14541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc5b0d20c6f1bca0994d00a347ff14e4ae64a14c
Gerrit-Change-Number: 14541
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 24 Oct 2019 17:52:33 +0000
Gerrit-HasComments: Yes