You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/10/06 09:41:20 UTC
[GitHub] [pulsar] fmiguelez opened a new pull request #8209: [Issue #8204][pulsar-broker] Fixes first automatic compaction issue
fmiguelez opened a new pull request #8209:
URL: https://github.com/apache/pulsar/pull/8209
Fixes #8204
### Motivation
Details are described in the issue and also on previous pull request #8205
### Modifications
If we have no durable subscriptions yet (e.g. when using `Reader` instead of `Consumer`) use ledger total size instead of estimated backlog size that will always be equal to 0 in this case.
### Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (comments)
- If a feature is not applicable for documentation, explain why? It is an internal change (no equivalent doc is available)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wolfstudy commented on pull request #8209: [Issue #8204][pulsar-broker] Fixes first automatic compaction issue
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #8209:
URL: https://github.com/apache/pulsar/pull/8209#issuecomment-746645441
@fmiguelez Please fix ci error. It seems to be a check-style problem, as follows:
```
Error: src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:[1273] (regexp) RegexpSingleline: Trailing whitespace
Error: Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.1:check (check-style) on project pulsar-broker: You have 1 Checkstyle violation. -> [Help 1]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on pull request #8209: [Issue #8204][pulsar-broker] Fixes first automatic compaction issue
Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #8209:
URL: https://github.com/apache/pulsar/pull/8209#issuecomment-704956855
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8209: [Issue #8204][pulsar-broker] Fixes first automatic compaction issue
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8209:
URL: https://github.com/apache/pulsar/pull/8209#issuecomment-757381173
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8209: [Issue #8204][pulsar-broker] Fixes first automatic compaction issue
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8209:
URL: https://github.com/apache/pulsar/pull/8209#issuecomment-753248844
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8209: [Issue #8204][pulsar-broker] Fixes first automatic compaction issue
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8209:
URL: https://github.com/apache/pulsar/pull/8209#issuecomment-751312722
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8209: [Issue #8204][pulsar-broker] Fixes first automatic compaction issue
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8209:
URL: https://github.com/apache/pulsar/pull/8209#issuecomment-752636997
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8209: [Issue #8204][pulsar-broker] Fixes first automatic compaction issue
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8209:
URL: https://github.com/apache/pulsar/pull/8209#issuecomment-757393535
@fmiguelez Please take a look at the failed test, seems related to this change. I copied the log here:
```
Error: Tests run: 36, Failures: 1, Errors: 0, Skipped: 1, Time elapsed: 9.187 s <<< FAILURE! - in org.apache.pulsar.broker.service.PersistentTopicTest
Error: testCompactionTriggeredAfterThresholdFirstInvocation(org.apache.pulsar.broker.service.PersistentTopicTest) Time elapsed: 0.021 s <<< FAILURE!
Wanted but not invoked:
compactor.compact(<any string>);
-> at org.apache.pulsar.broker.service.PersistentTopicTest.testCompactionTriggeredAfterThresholdFirstInvocation(PersistentTopicTest.java:1612)
Actually, there were zero interactions with this mock.
at org.apache.pulsar.broker.service.PersistentTopicTest.testCompactionTriggeredAfterThresholdFirstInvocation(PersistentTopicTest.java:1612)
at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:132)
at org.testng.internal.InvokeMethodRunnable.runOne(InvokeMethodRunnable.java:45)
at org.testng.internal.InvokeMethodRunnable.call(InvokeMethodRunnable.java:73)
at org.testng.internal.InvokeMethodRunnable.call(InvokeMethodRunnable.java:11)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8209: [Issue #8204][pulsar-broker] Fixes first automatic compaction issue
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8209:
URL: https://github.com/apache/pulsar/pull/8209#issuecomment-751955398
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8209: [Issue #8204][pulsar-broker] Fixes first automatic compaction issue
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8209:
URL: https://github.com/apache/pulsar/pull/8209#issuecomment-755851610
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] fmiguelez commented on pull request #8209: [Issue #8204][pulsar-broker] Fixes first automatic compaction issue
Posted by GitBox <gi...@apache.org>.
fmiguelez commented on pull request #8209:
URL: https://github.com/apache/pulsar/pull/8209#issuecomment-746167238
> @fmiguelez Could you please help take a look the checkstyle failure?
Is it now ok?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8209: [Issue #8204][pulsar-broker] Fixes first automatic compaction issue
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8209:
URL: https://github.com/apache/pulsar/pull/8209#issuecomment-753581927
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on pull request #8209: [Issue #8204][pulsar-broker] Fixes first automatic compaction issue
Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #8209:
URL: https://github.com/apache/pulsar/pull/8209#issuecomment-786305189
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] fmiguelez commented on pull request #8209: [Issue #8204][pulsar-broker] Fixes first automatic compaction issue
Posted by GitBox <gi...@apache.org>.
fmiguelez commented on pull request #8209:
URL: https://github.com/apache/pulsar/pull/8209#issuecomment-751666242
@codelipenghui is there anything left I should do?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8209: [Issue #8204][pulsar-broker] Fixes first automatic compaction issue
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8209:
URL: https://github.com/apache/pulsar/pull/8209#issuecomment-751553350
Don't merge this PR, CI with name Broker Group 2 is missed in the CI tests list.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8209: [Issue #8204][pulsar-broker] Fixes first automatic compaction issue
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8209:
URL: https://github.com/apache/pulsar/pull/8209#issuecomment-752955882
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on pull request #8209: [Issue #8204][pulsar-broker] Fixes first automatic compaction issue
Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #8209:
URL: https://github.com/apache/pulsar/pull/8209#issuecomment-705982047
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8209: [Issue #8204][pulsar-broker] Fixes first automatic compaction issue
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8209:
URL: https://github.com/apache/pulsar/pull/8209#issuecomment-755058669
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8209: [Issue #8204][pulsar-broker] Fixes first automatic compaction issue
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8209:
URL: https://github.com/apache/pulsar/pull/8209#issuecomment-753566496
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8209: [Issue #8204][pulsar-broker] Fixes first automatic compaction issue
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8209:
URL: https://github.com/apache/pulsar/pull/8209#issuecomment-755938670
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8209: [Issue #8204][pulsar-broker] Fixes first automatic compaction issue
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8209:
URL: https://github.com/apache/pulsar/pull/8209#issuecomment-751679353
@fmiguelez no, we are fixing the CI issues. After the CI fixed, I will try to rerun the test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8209: [Issue #8204][pulsar-broker] Fixes first automatic compaction issue
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8209:
URL: https://github.com/apache/pulsar/pull/8209#issuecomment-757381173
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wolfstudy commented on pull request #8209: [Issue #8204][pulsar-broker] Fixes first automatic compaction issue
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #8209:
URL: https://github.com/apache/pulsar/pull/8209#issuecomment-749589992
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on pull request #8209: [Issue #8204][pulsar-broker] Fixes first automatic compaction issue
Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #8209:
URL: https://github.com/apache/pulsar/pull/8209#issuecomment-705982047
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8209: [Issue #8204][pulsar-broker] Fixes first automatic compaction issue
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8209:
URL: https://github.com/apache/pulsar/pull/8209#issuecomment-744884436
@fmiguelez Could you please help take a look the checkstyle failure?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap merged pull request #8209: [Issue #8204][pulsar-broker] Fixes first automatic compaction issue
Posted by GitBox <gi...@apache.org>.
zymap merged pull request #8209:
URL: https://github.com/apache/pulsar/pull/8209
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8209: [Issue #8204][pulsar-broker] Fixes first automatic compaction issue
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8209:
URL: https://github.com/apache/pulsar/pull/8209#issuecomment-751701136
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8209: [Issue #8204][pulsar-broker] Fixes first automatic compaction issue
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8209:
URL: https://github.com/apache/pulsar/pull/8209#issuecomment-752802497
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8209: [Issue #8204][pulsar-broker] Fixes first automatic compaction issue
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8209:
URL: https://github.com/apache/pulsar/pull/8209#issuecomment-756012213
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org