Re: svn commit: r26818 - trunk

[Eric Gillespie <ep...@google.com>]

dlr@tigris.org writes:

> Author: dlr
> Date: Thu Sep 27 15:51:15 2007
> New Revision: 26818
> 
> Log:
> Allow Neon 0.27.2 without --disable-neon-version-check.

I've been building with 0.27.2 since this, and I notice we now
get a compile warning:

subversion/libsvn_ra_neon/session.c:861: warning: passing argument 2 of 'ne_set_progress' from incompatible pointer type

I seem to recall seeing a fix for this from Dan Christian not too
long ago.  Any reason that was not applied?  I haven't gone
looking for the thread yet...

Oh, I just asked Dan, and he said there might have been some
issue with compatibility.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r26818 - trunk

["Daniel L. Rall" <dl...@finemaltcoding.com>]

On Fri, 28 Sep 2007, Eric Gillespie wrote:

> dlr@tigris.org writes:
> 
> > Author: dlr
> > Date: Thu Sep 27 15:51:15 2007
> > New Revision: 26818
> > 
> > Log:
> > Allow Neon 0.27.2 without --disable-neon-version-check.
> 
> I've been building with 0.27.2 since this, and I notice we now
> get a compile warning:
> 
> subversion/libsvn_ra_neon/session.c:861: warning: passing argument 2 of 'ne_set_progress' from incompatible pointer type
... 
> Oh, I just asked Dan, and he said there might have been some
> issue with compatibility.

There was a problem with the APIs in the early/pre-0.27.x series of Neon
(which Dan's patch was written against).  The release notes for Neon 0.27.1
indicate that this problem may've been fixed, hopefully in a manner which
allows us to do something about it.

Dan C., want to give that patch another go?  We may need a SVN_NEON_0_27
macro define, which would be provided by build/ac-macros/neon.m4 (which
contains examples of how to do so).
-- 

Daniel Rall