You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tajo.apache.org by Hyunsik Choi <hy...@apache.org> on 2014/05/12 05:27:19 UTC

[FYI] Github pull request and Travis-CI available

Hi folks,

As I mentioned before, Github pull request for Tajo project is
available now. Also, I enabled Travis CI for pull request (TAJO-814).
I hope that you contribute patches conveniently by means of this
feature.

Thanks,
Hyunsik

Re: [FYI] Github pull request and Travis-CI available

Posted by Henry Saputra <he...@gmail.com>.
Hi Hyunsik,

Ah yes, I remember that announcement.
Thanks for reminding about ASF license contributions policy.

I think creating JIRA and reviews ticket for big or high impact changes is
beneficial to add audit trail and contributions tracking?

Like you said before, it should not be mandatory but recommended :)

This is just my 2-cents :)

- Henry

On Monday, May 12, 2014, Hyunsik Choi <hy...@apache.org> wrote:

> Hi Henry,
>
> I think that there is no license problem. Please see this mailing list
> thread:
>
> http://apache-database.10148.n7.nabble.com/No-more-license-check-box-after-Friday-td69039.html
>
> According to 5th term of Apache License 2.0, any contribution
> intentionally submitted to ASF project shell be under the Apache
> License 2.0 unless a contributor explicitly state otherwise,
>
> Now, I think that we don't need to force contributors to open one
> Github PR as well
> as one JIRA issues. If we add Github ticket numbers to committ
> message, we can track the issues. Anyway, I think that it's enough if
> we can track the issues discussed for the commit.
>
> But, I don't know how other guys think of this issue.
> I'd like to hear what you guys think.
>
> Cheers,
> Hyunsik
>
> On Mon, May 12, 2014 at 5:08 PM, Henry Saputra <henry.saputra@gmail.com<javascript:;>>
> wrote:
> > Hi Hyunsik,
> >
> > This is great news!
> > But I believe we will still require opening JIRA ticket for th Github
> PRs?
> >
> > Thus allowing us to make sure contributions are granted to ASF I suppose.
> >
> > - Henry
> >
> > On Sunday, May 11, 2014, Hyunsik Choi <hyunsik@apache.org <javascript:;>>
> wrote:
> >
> >> Hi folks,
> >>
> >> As I mentioned before, Github pull request for Tajo project is
> >> available now. Also, I enabled Travis CI for pull request (TAJO-814).
> >> I hope that you contribute patches conveniently by means of this
> >> feature.
> >>
> >> Thanks,
> >> Hyunsik
> >>
>

Re: [FYI] Github pull request and Travis-CI available

Posted by Hyunsik Choi <hy...@apache.org>.
Hi Henry,

I think that there is no license problem. Please see this mailing list thread:
http://apache-database.10148.n7.nabble.com/No-more-license-check-box-after-Friday-td69039.html

According to 5th term of Apache License 2.0, any contribution
intentionally submitted to ASF project shell be under the Apache
License 2.0 unless a contributor explicitly state otherwise,

Now, I think that we don't need to force contributors to open one
Github PR as well
as one JIRA issues. If we add Github ticket numbers to committ
message, we can track the issues. Anyway, I think that it's enough if
we can track the issues discussed for the commit.

But, I don't know how other guys think of this issue.
I'd like to hear what you guys think.

Cheers,
Hyunsik

On Mon, May 12, 2014 at 5:08 PM, Henry Saputra <he...@gmail.com> wrote:
> Hi Hyunsik,
>
> This is great news!
> But I believe we will still require opening JIRA ticket for th Github PRs?
>
> Thus allowing us to make sure contributions are granted to ASF I suppose.
>
> - Henry
>
> On Sunday, May 11, 2014, Hyunsik Choi <hy...@apache.org> wrote:
>
>> Hi folks,
>>
>> As I mentioned before, Github pull request for Tajo project is
>> available now. Also, I enabled Travis CI for pull request (TAJO-814).
>> I hope that you contribute patches conveniently by means of this
>> feature.
>>
>> Thanks,
>> Hyunsik
>>

Re: [FYI] Github pull request and Travis-CI available

Posted by Hyunsik Choi <hy...@apache.org>.
Hi Henry,

I think that there is no license problem. Please see this mailing list thread:
http://apache-database.10148.n7.nabble.com/No-more-license-check-box-after-Friday-td69039.html

According to 5th term of Apache License 2.0, any contribution
intentionally submitted to ASF project shell be under the Apache
License 2.0 unless a contributor explicitly state otherwise,

Now, I think that we don't need to force contributors to open one
Github PR as well
as one JIRA issues. If we add Github ticket numbers to committ
message, we can track the issues. Anyway, I think that it's enough if
we can track the issues discussed for the commit.

But, I don't know how other guys think of this issue.
I'd like to hear what you guys think.

Cheers,
Hyunsik

On Mon, May 12, 2014 at 5:08 PM, Henry Saputra <he...@gmail.com> wrote:
> Hi Hyunsik,
>
> This is great news!
> But I believe we will still require opening JIRA ticket for th Github PRs?
>
> Thus allowing us to make sure contributions are granted to ASF I suppose.
>
> - Henry
>
> On Sunday, May 11, 2014, Hyunsik Choi <hy...@apache.org> wrote:
>
>> Hi folks,
>>
>> As I mentioned before, Github pull request for Tajo project is
>> available now. Also, I enabled Travis CI for pull request (TAJO-814).
>> I hope that you contribute patches conveniently by means of this
>> feature.
>>
>> Thanks,
>> Hyunsik
>>

Re: [FYI] Github pull request and Travis-CI available

Posted by Henry Saputra <he...@gmail.com>.
Hi Hyunsik,

This is great news!
But I believe we will still require opening JIRA ticket for th Github PRs?

Thus allowing us to make sure contributions are granted to ASF I suppose.

- Henry

On Sunday, May 11, 2014, Hyunsik Choi <hy...@apache.org> wrote:

> Hi folks,
>
> As I mentioned before, Github pull request for Tajo project is
> available now. Also, I enabled Travis CI for pull request (TAJO-814).
> I hope that you contribute patches conveniently by means of this
> feature.
>
> Thanks,
> Hyunsik
>