You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/03 13:38:59 UTC

[GitHub] [airflow] potiuk edited a comment on issue #11112: Release airflow upgrade_check as separate package

potiuk edited a comment on issue #11112:
URL: https://github.com/apache/airflow/issues/11112#issuecomment-720730714


   Comment from my side as promised:
   
    I think we can use a similar process I implemented for docker image separation. I have a working solution here: https://github.com/potiuk/airflow-docker
   
   The "main" branch there is just synchronizing the repo. The "master" and "v1-10-stable" are just mirrors of "master" and "v1-10-stable" from airflow (filtered to only contain The Dockerfile  + relevant files). It extracts only the relevant paths/commits. So if we structure the "upgrade-check" properly, it can extract only the "upgrade-check" relevant stuff to this repo.
   
   Benefits: 
   
   * We do not have to manually synchronize v1-10 airflow code to such a project (it happens automatically).
   * We can continue running full tests and whole CI checks in airflow - where we have all the pre-commits, tests, etc. 
   * The synchronization is scheduled and runs in "pull" mode from airflow's public repo, so there is no need for additional authentication (and secrets).
   
   Caveats:
   * for now the "main" branch contains the .github/workflow schedule and the code that synchronizes the repos. It does not contain the actual Dockerfile + scripts. This is because the scheduled workflows must reside in the "main" branch and I did not want to mix the "sync" code with the actual Dockerfiles. However, it should be entirely possible to have a single "main branch" containing both the "sync" code and the "upgrade-check" code. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org