You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2016/03/10 01:25:48 UTC
Review Request 44602: Adding non-role-exclusive dedicated constraint
support
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44602/
-----------------------------------------------------------
Review request for Aurora, Steve Niemitz and Bill Farner.
Repository: aurora
Description
-------
Ported from https://github.com/tellapart/aurora/commit/76f978c76cc1377e19e602f7e0d050f7ce353562.
Diffs
-----
NEWS 0aa7f5e192ef17b95471e34a5408491999bcdeeb
docs/deploying-aurora-scheduler.md 10952efc2725b031e9a8de35ba9f4e5c20ed99d9
src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 6300e5f83b039a9798e7093f6b46c84566e507e0
src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java d2789d0eaaeba99fcff3412f1abdd29a09d6514d
Diff: https://reviews.apache.org/r/44602/diff/
Testing
-------
./gradlew -Pq build
Thanks,
Maxim Khutornenko
Re: Review Request 44602: Adding non-role-exclusive dedicated
constraint support
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44602/#review122847
-----------------------------------------------------------
@ReviewBot retry
- Maxim Khutornenko
On March 10, 2016, 12:25 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44602/
> -----------------------------------------------------------
>
> (Updated March 10, 2016, 12:25 a.m.)
>
>
> Review request for Aurora, Steve Niemitz and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Ported from https://github.com/tellapart/aurora/commit/76f978c76cc1377e19e602f7e0d050f7ce353562.
>
>
> Diffs
> -----
>
> NEWS 0aa7f5e192ef17b95471e34a5408491999bcdeeb
> docs/deploying-aurora-scheduler.md 10952efc2725b031e9a8de35ba9f4e5c20ed99d9
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 6300e5f83b039a9798e7093f6b46c84566e507e0
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java d2789d0eaaeba99fcff3412f1abdd29a09d6514d
>
> Diff: https://reviews.apache.org/r/44602/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 44602: Adding non-role-exclusive dedicated
constraint support
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44602/#review122850
-----------------------------------------------------------
@ReviewBot retry please...
- Maxim Khutornenko
On March 10, 2016, 12:25 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44602/
> -----------------------------------------------------------
>
> (Updated March 10, 2016, 12:25 a.m.)
>
>
> Review request for Aurora, Steve Niemitz and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Ported from https://github.com/tellapart/aurora/commit/76f978c76cc1377e19e602f7e0d050f7ce353562.
>
>
> Diffs
> -----
>
> NEWS 0aa7f5e192ef17b95471e34a5408491999bcdeeb
> docs/deploying-aurora-scheduler.md 10952efc2725b031e9a8de35ba9f4e5c20ed99d9
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 6300e5f83b039a9798e7093f6b46c84566e507e0
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java d2789d0eaaeba99fcff3412f1abdd29a09d6514d
>
> Diff: https://reviews.apache.org/r/44602/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 44602: Adding non-role-exclusive dedicated
constraint support
Posted by Steve Niemitz <sn...@twitter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44602/#review122841
-----------------------------------------------------------
Ship it!
Oh neat, we're doing this? We've been running this patch for 6+ months now with no issues.
- Steve Niemitz
On March 10, 2016, 12:25 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44602/
> -----------------------------------------------------------
>
> (Updated March 10, 2016, 12:25 a.m.)
>
>
> Review request for Aurora, Steve Niemitz and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Ported from https://github.com/tellapart/aurora/commit/76f978c76cc1377e19e602f7e0d050f7ce353562.
>
>
> Diffs
> -----
>
> NEWS 0aa7f5e192ef17b95471e34a5408491999bcdeeb
> docs/deploying-aurora-scheduler.md 10952efc2725b031e9a8de35ba9f4e5c20ed99d9
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 6300e5f83b039a9798e7093f6b46c84566e507e0
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java d2789d0eaaeba99fcff3412f1abdd29a09d6514d
>
> Diff: https://reviews.apache.org/r/44602/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 44602: Adding non-role-exclusive dedicated
constraint support
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44602/#review122861
-----------------------------------------------------------
Ship it!
Master (fbfeca3) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 10, 2016, 12:25 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44602/
> -----------------------------------------------------------
>
> (Updated March 10, 2016, 12:25 a.m.)
>
>
> Review request for Aurora, Steve Niemitz and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Ported from https://github.com/tellapart/aurora/commit/76f978c76cc1377e19e602f7e0d050f7ce353562.
>
>
> Diffs
> -----
>
> NEWS 0aa7f5e192ef17b95471e34a5408491999bcdeeb
> docs/deploying-aurora-scheduler.md 10952efc2725b031e9a8de35ba9f4e5c20ed99d9
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 6300e5f83b039a9798e7093f6b46c84566e507e0
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java d2789d0eaaeba99fcff3412f1abdd29a09d6514d
>
> Diff: https://reviews.apache.org/r/44602/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 44602: Adding non-role-exclusive dedicated
constraint support
Posted by Bill Farner <wf...@apache.org>.
> On March 10, 2016, 12:21 a.m., Stephan Erb wrote:
> > docs/deploying-aurora-scheduler.md, line 286
> > <https://reviews.apache.org/r/44602/diff/1/?file=1293788#file1293788line286>
> >
> > I don't find this sentence very clear. Would probably help to have a more explicit example instead of speaking of a 'correnspondent attribute'.
> >
> > The way this is written right now, it is not 100% clear if I have to put the '*' on the slave attribute, the job constraint or both.
I completely agree. Consider avoiding 'foo' to ensure the description isn't too abstract. Maybe even describe the use case you're thinking of right now.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44602/#review122898
-----------------------------------------------------------
On March 9, 2016, 4:25 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44602/
> -----------------------------------------------------------
>
> (Updated March 9, 2016, 4:25 p.m.)
>
>
> Review request for Aurora, Steve Niemitz and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Ported from https://github.com/tellapart/aurora/commit/76f978c76cc1377e19e602f7e0d050f7ce353562.
>
>
> Diffs
> -----
>
> NEWS 0aa7f5e192ef17b95471e34a5408491999bcdeeb
> docs/deploying-aurora-scheduler.md 10952efc2725b031e9a8de35ba9f4e5c20ed99d9
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 6300e5f83b039a9798e7093f6b46c84566e507e0
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java d2789d0eaaeba99fcff3412f1abdd29a09d6514d
>
> Diff: https://reviews.apache.org/r/44602/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 44602: Adding non-role-exclusive dedicated
constraint support
Posted by Maxim Khutornenko <ma...@apache.org>.
> On March 10, 2016, 8:21 a.m., Stephan Erb wrote:
> > docs/deploying-aurora-scheduler.md, line 286
> > <https://reviews.apache.org/r/44602/diff/1/?file=1293788#file1293788line286>
> >
> > I don't find this sentence very clear. Would probably help to have a more explicit example instead of speaking of a 'correnspondent attribute'.
> >
> > The way this is written right now, it is not 100% clear if I have to put the '*' on the slave attribute, the job constraint or both.
>
> Bill Farner wrote:
> I completely agree. Consider avoiding 'foo' to ensure the description isn't too abstract. Maybe even describe the use case you're thinking of right now.
Fair enough. Reworded and added examples for both use cases.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44602/#review122898
-----------------------------------------------------------
On March 10, 2016, 12:25 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44602/
> -----------------------------------------------------------
>
> (Updated March 10, 2016, 12:25 a.m.)
>
>
> Review request for Aurora, Steve Niemitz and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Ported from https://github.com/tellapart/aurora/commit/76f978c76cc1377e19e602f7e0d050f7ce353562.
>
>
> Diffs
> -----
>
> NEWS 0aa7f5e192ef17b95471e34a5408491999bcdeeb
> docs/deploying-aurora-scheduler.md 10952efc2725b031e9a8de35ba9f4e5c20ed99d9
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 6300e5f83b039a9798e7093f6b46c84566e507e0
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java d2789d0eaaeba99fcff3412f1abdd29a09d6514d
>
> Diff: https://reviews.apache.org/r/44602/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 44602: Adding non-role-exclusive dedicated
constraint support
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44602/#review122898
-----------------------------------------------------------
docs/deploying-aurora-scheduler.md (line 286)
<https://reviews.apache.org/r/44602/#comment185004>
I don't find this sentence very clear. Would probably help to have a more explicit example instead of speaking of a 'correnspondent attribute'.
The way this is written right now, it is not 100% clear if I have to put the '*' on the slave attribute, the job constraint or both.
- Stephan Erb
On March 10, 2016, 1:25 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44602/
> -----------------------------------------------------------
>
> (Updated March 10, 2016, 1:25 a.m.)
>
>
> Review request for Aurora, Steve Niemitz and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Ported from https://github.com/tellapart/aurora/commit/76f978c76cc1377e19e602f7e0d050f7ce353562.
>
>
> Diffs
> -----
>
> NEWS 0aa7f5e192ef17b95471e34a5408491999bcdeeb
> docs/deploying-aurora-scheduler.md 10952efc2725b031e9a8de35ba9f4e5c20ed99d9
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 6300e5f83b039a9798e7093f6b46c84566e507e0
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java d2789d0eaaeba99fcff3412f1abdd29a09d6514d
>
> Diff: https://reviews.apache.org/r/44602/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 44602: Adding non-role-exclusive dedicated
constraint support
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44602/#review122843
-----------------------------------------------------------
Master (fbfeca3) is red with this patch.
./build-support/jenkins/build.sh
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
E0310 00:42:41.608119 27933 thermos_task_runner.py:234] Could not quitquitquit runner: Cannot take control of a task in terminal state.
generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
[1m[31m 1 failed, 661 passed, 5 skipped, 1 warnings in 341.24 seconds [0m
FAILURE
00:44:02 06:28 [complete][31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 10, 2016, 12:25 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44602/
> -----------------------------------------------------------
>
> (Updated March 10, 2016, 12:25 a.m.)
>
>
> Review request for Aurora, Steve Niemitz and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Ported from https://github.com/tellapart/aurora/commit/76f978c76cc1377e19e602f7e0d050f7ce353562.
>
>
> Diffs
> -----
>
> NEWS 0aa7f5e192ef17b95471e34a5408491999bcdeeb
> docs/deploying-aurora-scheduler.md 10952efc2725b031e9a8de35ba9f4e5c20ed99d9
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 6300e5f83b039a9798e7093f6b46c84566e507e0
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java d2789d0eaaeba99fcff3412f1abdd29a09d6514d
>
> Diff: https://reviews.apache.org/r/44602/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 44602: Adding non-role-exclusive dedicated
constraint support
Posted by Maxim Khutornenko <ma...@apache.org>.
> On March 10, 2016, 6:56 p.m., Joshua Cohen wrote:
> > docs/deploying-aurora-scheduler.md, lines 289-291
> > <https://reviews.apache.org/r/44602/diff/2/?file=1294546#file1294546line289>
> >
> > I think this "only" is misleading here? If I understand correctly, a task, `devcluster/www-data/prod/hello` with a dedicated constraint of `*/web.multi` could be scheduled on an agent that has a dedicated attribute of *either* `*/web.multi` or `www-data/web.multi`, correct?
Not really. Task constraint value must match mesos attribute value exactly. The `*` is used to remove the role match requirement but does not go as far as having a regex-like meaning you are suggesting. That would require making `AttributeFilter` syntax sensitive.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44602/#review122959
-----------------------------------------------------------
On March 10, 2016, 6:44 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44602/
> -----------------------------------------------------------
>
> (Updated March 10, 2016, 6:44 p.m.)
>
>
> Review request for Aurora, Steve Niemitz and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Ported from https://github.com/tellapart/aurora/commit/76f978c76cc1377e19e602f7e0d050f7ce353562.
>
>
> Diffs
> -----
>
> NEWS 0aa7f5e192ef17b95471e34a5408491999bcdeeb
> docs/deploying-aurora-scheduler.md 10952efc2725b031e9a8de35ba9f4e5c20ed99d9
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 6300e5f83b039a9798e7093f6b46c84566e507e0
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java d2789d0eaaeba99fcff3412f1abdd29a09d6514d
>
> Diff: https://reviews.apache.org/r/44602/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 44602: Adding non-role-exclusive dedicated
constraint support
Posted by Joshua Cohen <jc...@apache.org>.
> On March 10, 2016, 6:56 p.m., Joshua Cohen wrote:
> > docs/deploying-aurora-scheduler.md, lines 289-291
> > <https://reviews.apache.org/r/44602/diff/2/?file=1294546#file1294546line289>
> >
> > I think this "only" is misleading here? If I understand correctly, a task, `devcluster/www-data/prod/hello` with a dedicated constraint of `*/web.multi` could be scheduled on an agent that has a dedicated attribute of *either* `*/web.multi` or `www-data/web.multi`, correct?
>
> Maxim Khutornenko wrote:
> Not really. Task constraint value must match mesos attribute value exactly. The `*` is used to remove the role match requirement but does not go as far as having a regex-like meaning you are suggesting. That would require making `AttributeFilter` syntax sensitive.
Ahh, I see. This is definitely a bit confusing (the feature itself, not the documentation) :/.
- Joshua
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44602/#review122959
-----------------------------------------------------------
On March 10, 2016, 6:44 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44602/
> -----------------------------------------------------------
>
> (Updated March 10, 2016, 6:44 p.m.)
>
>
> Review request for Aurora, Steve Niemitz and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Ported from https://github.com/tellapart/aurora/commit/76f978c76cc1377e19e602f7e0d050f7ce353562.
>
>
> Diffs
> -----
>
> NEWS 0aa7f5e192ef17b95471e34a5408491999bcdeeb
> docs/deploying-aurora-scheduler.md 10952efc2725b031e9a8de35ba9f4e5c20ed99d9
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 6300e5f83b039a9798e7093f6b46c84566e507e0
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java d2789d0eaaeba99fcff3412f1abdd29a09d6514d
>
> Diff: https://reviews.apache.org/r/44602/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 44602: Adding non-role-exclusive dedicated
constraint support
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44602/#review122959
-----------------------------------------------------------
docs/deploying-aurora-scheduler.md (lines 289 - 291)
<https://reviews.apache.org/r/44602/#comment185053>
I think this "only" is misleading here? If I understand correctly, a task, `devcluster/www-data/prod/hello` with a dedicated constraint of `*/web.multi` could be scheduled on an agent that has a dedicated attribute of *either* `*/web.multi` or `www-data/web.multi`, correct?
- Joshua Cohen
On March 10, 2016, 6:44 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44602/
> -----------------------------------------------------------
>
> (Updated March 10, 2016, 6:44 p.m.)
>
>
> Review request for Aurora, Steve Niemitz and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Ported from https://github.com/tellapart/aurora/commit/76f978c76cc1377e19e602f7e0d050f7ce353562.
>
>
> Diffs
> -----
>
> NEWS 0aa7f5e192ef17b95471e34a5408491999bcdeeb
> docs/deploying-aurora-scheduler.md 10952efc2725b031e9a8de35ba9f4e5c20ed99d9
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 6300e5f83b039a9798e7093f6b46c84566e507e0
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java d2789d0eaaeba99fcff3412f1abdd29a09d6514d
>
> Diff: https://reviews.apache.org/r/44602/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 44602: Adding non-role-exclusive dedicated
constraint support
Posted by Maxim Khutornenko <ma...@apache.org>.
> On March 10, 2016, 8:10 p.m., Bill Farner wrote:
> > docs/deploying-aurora-scheduler.md, line 286
> > <https://reviews.apache.org/r/44602/diff/2/?file=1294546#file1294546line286>
> >
> > How about this wording for the first sentence?
> >
> > | A wildcard (`*`) may be used for the role portion of the dedicated attribute, which will allow any owner to elect for a job to run on the host(s).
Fine with me.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44602/#review122981
-----------------------------------------------------------
On March 10, 2016, 6:44 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44602/
> -----------------------------------------------------------
>
> (Updated March 10, 2016, 6:44 p.m.)
>
>
> Review request for Aurora, Steve Niemitz and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Ported from https://github.com/tellapart/aurora/commit/76f978c76cc1377e19e602f7e0d050f7ce353562.
>
>
> Diffs
> -----
>
> NEWS 0aa7f5e192ef17b95471e34a5408491999bcdeeb
> docs/deploying-aurora-scheduler.md 10952efc2725b031e9a8de35ba9f4e5c20ed99d9
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 6300e5f83b039a9798e7093f6b46c84566e507e0
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java d2789d0eaaeba99fcff3412f1abdd29a09d6514d
>
> Diff: https://reviews.apache.org/r/44602/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 44602: Adding non-role-exclusive dedicated
constraint support
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44602/#review122981
-----------------------------------------------------------
Ship it!
docs/deploying-aurora-scheduler.md (line 286)
<https://reviews.apache.org/r/44602/#comment185076>
How about this wording for the first sentence?
| A wildcard (`*`) may be used for the role portion of the dedicated attribute, which will allow any owner to elect for a job to run on the host(s).
- Bill Farner
On March 10, 2016, 10:44 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44602/
> -----------------------------------------------------------
>
> (Updated March 10, 2016, 10:44 a.m.)
>
>
> Review request for Aurora, Steve Niemitz and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Ported from https://github.com/tellapart/aurora/commit/76f978c76cc1377e19e602f7e0d050f7ce353562.
>
>
> Diffs
> -----
>
> NEWS 0aa7f5e192ef17b95471e34a5408491999bcdeeb
> docs/deploying-aurora-scheduler.md 10952efc2725b031e9a8de35ba9f4e5c20ed99d9
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 6300e5f83b039a9798e7093f6b46c84566e507e0
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java d2789d0eaaeba99fcff3412f1abdd29a09d6514d
>
> Diff: https://reviews.apache.org/r/44602/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 44602: Adding non-role-exclusive dedicated
constraint support
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44602/#review122963
-----------------------------------------------------------
Master (31a538f) is red with this patch.
./build-support/jenkins/build.sh
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
E0310 19:07:29.982023 22845 thermos_task_runner.py:234] Could not quitquitquit runner: Cannot take control of a task in terminal state.
generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
[1m[31m 1 failed, 661 passed, 5 skipped, 1 warnings in 311.44 seconds [0m
FAILURE
19:08:34 05:58 [complete][31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 10, 2016, 6:44 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44602/
> -----------------------------------------------------------
>
> (Updated March 10, 2016, 6:44 p.m.)
>
>
> Review request for Aurora, Steve Niemitz and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Ported from https://github.com/tellapart/aurora/commit/76f978c76cc1377e19e602f7e0d050f7ce353562.
>
>
> Diffs
> -----
>
> NEWS 0aa7f5e192ef17b95471e34a5408491999bcdeeb
> docs/deploying-aurora-scheduler.md 10952efc2725b031e9a8de35ba9f4e5c20ed99d9
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 6300e5f83b039a9798e7093f6b46c84566e507e0
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java d2789d0eaaeba99fcff3412f1abdd29a09d6514d
>
> Diff: https://reviews.apache.org/r/44602/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 44602: Adding non-role-exclusive dedicated
constraint support
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44602/
-----------------------------------------------------------
(Updated March 10, 2016, 8:19 p.m.)
Review request for Aurora, Steve Niemitz and Bill Farner.
Changes
-------
Bill's comment.
Repository: aurora
Description
-------
Ported from https://github.com/tellapart/aurora/commit/76f978c76cc1377e19e602f7e0d050f7ce353562.
Diffs (updated)
-----
NEWS 0aa7f5e192ef17b95471e34a5408491999bcdeeb
docs/deploying-aurora-scheduler.md 10952efc2725b031e9a8de35ba9f4e5c20ed99d9
src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 6300e5f83b039a9798e7093f6b46c84566e507e0
src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java d2789d0eaaeba99fcff3412f1abdd29a09d6514d
Diff: https://reviews.apache.org/r/44602/diff/
Testing
-------
./gradlew -Pq build
Thanks,
Maxim Khutornenko
Re: Review Request 44602: Adding non-role-exclusive dedicated
constraint support
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44602/
-----------------------------------------------------------
(Updated March 10, 2016, 6:44 p.m.)
Review request for Aurora, Steve Niemitz and Bill Farner.
Changes
-------
Updated docs.
Repository: aurora
Description
-------
Ported from https://github.com/tellapart/aurora/commit/76f978c76cc1377e19e602f7e0d050f7ce353562.
Diffs (updated)
-----
NEWS 0aa7f5e192ef17b95471e34a5408491999bcdeeb
docs/deploying-aurora-scheduler.md 10952efc2725b031e9a8de35ba9f4e5c20ed99d9
src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 6300e5f83b039a9798e7093f6b46c84566e507e0
src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java d2789d0eaaeba99fcff3412f1abdd29a09d6514d
Diff: https://reviews.apache.org/r/44602/diff/
Testing
-------
./gradlew -Pq build
Thanks,
Maxim Khutornenko
Re: Review Request 44602: Adding non-role-exclusive dedicated
constraint support
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44602/#review122849
-----------------------------------------------------------
Master (fbfeca3) is red with this patch.
./build-support/jenkins/build.sh
[1m proxy_driver = ProxyDriver()[0m
[1m with temporary_dir() as checkpoint_root:[0m
[1m te = AuroraExecutor([0m
[1m> runner_provider=make_provider(checkpoint_root),[0m
[1m sandbox_provider=DefaultTestSandboxProvider())[0m
src/test/python/apache/aurora/executor/test_thermos_executor.py:580:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
src/test/python/apache/aurora/executor/test_thermos_executor.py:193: in make_provider
[1m pex_location=thermos_runner_path(),[0m
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
build = True
[1m def thermos_runner_path(build=True):[0m
[1m if not build:[0m
[1m return getattr(thermos_runner_path, 'value', None)[0m
[1m [0m
[1m if not hasattr(thermos_runner_path, 'value'):[0m
[1m pex_dir = safe_mkdtemp()[0m
[1m> assert subprocess.call(["./pants", "--pants-distdir=%s" % pex_dir, "binary",[0m
[1m "src/main/python/apache/thermos/runner:thermos_runner"]) == 0[0m
[1m[31mE assert 1 == 0[0m
[1m[31mE + where 1 = <function call at 0x7f9976f3db18>(['./pants', '--pants-distdir=/tmp/user/10021/tmpjRfL5e', 'binary', 'src/main/python/apache/thermos/runner:thermos_runner'])[0m
[1m[31mE + where <function call at 0x7f9976f3db18> = subprocess.call[0m
src/test/python/apache/aurora/executor/test_thermos_executor.py:185: AssertionError
-------------- Captured stderr call --------------
Traceback (most recent call last):
File "/home/jenkins/.cache/pants/setup/bootstrap-Linux-x86_64/0.0.75/bin/pants", line 7, in <module>
from pants.bin.pants_exe import main
ImportError: No module named pants.bin.pants_exe
generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
[1m[31m 16 failed, 638 passed, 5 skipped, 1 warnings, 8 error in 211.93 seconds [0m
FAILURE
01:11:52 04:15 [complete][31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 10, 2016, 12:25 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44602/
> -----------------------------------------------------------
>
> (Updated March 10, 2016, 12:25 a.m.)
>
>
> Review request for Aurora, Steve Niemitz and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Ported from https://github.com/tellapart/aurora/commit/76f978c76cc1377e19e602f7e0d050f7ce353562.
>
>
> Diffs
> -----
>
> NEWS 0aa7f5e192ef17b95471e34a5408491999bcdeeb
> docs/deploying-aurora-scheduler.md 10952efc2725b031e9a8de35ba9f4e5c20ed99d9
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 6300e5f83b039a9798e7093f6b46c84566e507e0
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java d2789d0eaaeba99fcff3412f1abdd29a09d6514d
>
> Diff: https://reviews.apache.org/r/44602/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>