You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2016/02/06 18:04:49 UTC
Review Request 43284: Wait for perf statistics processes exit.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43284/
-----------------------------------------------------------
Review request for mesos and Jan Schlicht.
Bugs: MESOS-4039
https://issues.apache.org/jira/browse/MESOS-4039
Repository: mesos
Description
-------
Wait for perf statistics processes exit.
Diffs
-----
src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp 65e731886b9e5cac07ae3ad6398faf8f50de5650
src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp 5ef4ae5c468580352cd16e7716b9ca4c0acde659
Diff: https://reviews.apache.org/r/43284/diff/
Testing
-------
Without this patch, when running
```
sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="PerfEventIsolatorTest.ROOT_CGROUPS_Sample" --verbose
```
, would got this error
```
[----------] Global test environment tear-down
../../src/tests/environment.cpp:732: Failure
Failed
Tests completed with child processes remaining:
-+- 16501 /home/haosdent/mesos/build/src/.libs/lt-mesos-tests --gtest_filter=PerfEventIsolatorTest.ROOT_CGROUPS_Sample --verbose
|-+- 16580 /home/haosdent/mesos/build/src/.libs/lt-mesos-tests --gtest_filter=PerfEventIsolatorTest.ROOT_CGROUPS_Sample --verbose
| -+- 16582 perf stat --all-cpus --field-separator , --log-fd 1 --event cycles --cgroup mesos/239d30bb-f7a1-413b-9d99-0914149d5899 --event task-clock --cgroup mesos/239d30bb-f7a1-413b-9d99-0914149d5899 -- sleep 0.25
| --- 16584 sleep 0.25
--- 16581 ()
[==========] 1 test from 1 test case ran. (4095 ms total)
```
Thanks,
haosdent huang