You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anindya Sinha <an...@apple.com> on 2017/01/09 22:37:10 UTC
Re: Review Request 45962: Updated a persistent volume test framework
to include shared volumes.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45962/
-----------------------------------------------------------
(Updated Jan. 9, 2017, 10:37 p.m.)
Review request for mesos, Greg Mann, Jie Yu, and Jiang Yan Xu.
Changes
-------
Rebase.
Bugs: MESOS-4431
https://issues.apache.org/jira/browse/MESOS-4431
Repository: mesos
Description
-------
Updated a persistent volume test framework to include shared volumes.
Diffs (updated)
-----
src/examples/persistent_volume_framework.cpp 9d45bb496c4cf378af429b5aa970bf81450e482a
Diff: https://reviews.apache.org/r/45962/diff/
Testing
-------
New test framework for shared resources added.
Tests successful.
Thanks,
Anindya Sinha
Re: Review Request 45962: Updated a persistent volume test framework
to include shared volumes.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45962/
-----------------------------------------------------------
(Updated Feb. 3, 2017, 10:01 p.m.)
Review request for mesos, Greg Mann, Jie Yu, and Jiang Yan Xu.
Changes
-------
Refactor.
Bugs: MESOS-4431
https://issues.apache.org/jira/browse/MESOS-4431
Repository: mesos
Description
-------
Updated a persistent volume test framework to include shared volumes.
Diffs (updated)
-----
src/examples/persistent_volume_framework.cpp 9d45bb496c4cf378af429b5aa970bf81450e482a
Diff: https://reviews.apache.org/r/45962/diff/
Testing
-------
New test framework for shared resources added.
Tests successful.
Thanks,
Anindya Sinha
Re: Review Request 45962: Updated a persistent volume test framework
to include shared volumes.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45962/
-----------------------------------------------------------
(Updated Feb. 1, 2017, 10:45 p.m.)
Review request for mesos, Greg Mann, Jie Yu, and Jiang Yan Xu.
Changes
-------
Rebased after batch allocation patch was merged.
Bugs: MESOS-4431
https://issues.apache.org/jira/browse/MESOS-4431
Repository: mesos
Description
-------
Updated a persistent volume test framework to include shared volumes.
Diffs (updated)
-----
src/examples/persistent_volume_framework.cpp 9d45bb496c4cf378af429b5aa970bf81450e482a
Diff: https://reviews.apache.org/r/45962/diff/
Testing
-------
New test framework for shared resources added.
Tests successful.
Thanks,
Anindya Sinha
Re: Review Request 45962: Updated a persistent volume test framework
to include shared volumes.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45962/
-----------------------------------------------------------
(Updated Jan. 31, 2017, 5:58 a.m.)
Review request for mesos, Greg Mann, Jie Yu, and Jiang Yan Xu.
Changes
-------
Rebased.
Bugs: MESOS-4431
https://issues.apache.org/jira/browse/MESOS-4431
Repository: mesos
Description
-------
Updated a persistent volume test framework to include shared volumes.
Diffs (updated)
-----
src/examples/persistent_volume_framework.cpp 9d45bb496c4cf378af429b5aa970bf81450e482a
Diff: https://reviews.apache.org/r/45962/diff/
Testing
-------
New test framework for shared resources added.
Tests successful.
Thanks,
Anindya Sinha
Re: Review Request 45962: Updated a persistent volume test framework
to include shared volumes.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45962/
-----------------------------------------------------------
(Updated Jan. 26, 2017, 10:06 p.m.)
Review request for mesos, Greg Mann, Jie Yu, and Jiang Yan Xu.
Changes
-------
Addressed review comments.
Bugs: MESOS-4431
https://issues.apache.org/jira/browse/MESOS-4431
Repository: mesos
Description
-------
Updated a persistent volume test framework to include shared volumes.
Diffs (updated)
-----
src/examples/persistent_volume_framework.cpp 9d45bb496c4cf378af429b5aa970bf81450e482a
Diff: https://reviews.apache.org/r/45962/diff/
Testing
-------
New test framework for shared resources added.
Tests successful.
Thanks,
Anindya Sinha
Re: Review Request 45962: Updated a persistent volume test framework
to include shared volumes.
Posted by Jiang Yan Xu <ya...@jxu.me>.
> On Jan. 25, 2017, 5:27 p.m., Jiang Yan Xu wrote:
> > Just a minor comment plus the reply to a previous comment.
This can go in before /r/55359/ since that is a refactor.
- Jiang Yan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45962/#review163070
-----------------------------------------------------------
On Jan. 9, 2017, 2:37 p.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45962/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2017, 2:37 p.m.)
>
>
> Review request for mesos, Greg Mann, Jie Yu, and Jiang Yan Xu.
>
>
> Bugs: MESOS-4431
> https://issues.apache.org/jira/browse/MESOS-4431
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated a persistent volume test framework to include shared volumes.
>
>
> Diffs
> -----
>
> src/examples/persistent_volume_framework.cpp 9d45bb496c4cf378af429b5aa970bf81450e482a
>
> Diff: https://reviews.apache.org/r/45962/diff/
>
>
> Testing
> -------
>
> New test framework for shared resources added.
> Tests successful.
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 45962: Updated a persistent volume test framework
to include shared volumes.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45962/#review163070
-----------------------------------------------------------
Fix it, then Ship it!
Just a minor comment plus the reply to a previous comment.
src/examples/persistent_volume_framework.cpp (lines 248 - 249)
<https://reviews.apache.org/r/45962/#comment234504>
This
```
} else {
if (...) {
}
}
```
looks odd.
You could have done `else if` but in this particular case I guess `break` sonner is better? (A simple condition check + keep the bulk of the logic less indented).
- Jiang Yan Xu
On Jan. 9, 2017, 2:37 p.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45962/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2017, 2:37 p.m.)
>
>
> Review request for mesos, Greg Mann, Jie Yu, and Jiang Yan Xu.
>
>
> Bugs: MESOS-4431
> https://issues.apache.org/jira/browse/MESOS-4431
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated a persistent volume test framework to include shared volumes.
>
>
> Diffs
> -----
>
> src/examples/persistent_volume_framework.cpp 9d45bb496c4cf378af429b5aa970bf81450e482a
>
> Diff: https://reviews.apache.org/r/45962/diff/
>
>
> Testing
> -------
>
> New test framework for shared resources added.
> Tests successful.
>
>
> Thanks,
>
> Anindya Sinha
>
>