You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by woshiaxie <gi...@git.apache.org> on 2017/08/04 01:47:12 UTC
[GitHub] incubator-weex pull request #572: modify WXValidateProcessor to make options...
GitHub user woshiaxie opened a pull request:
https://github.com/apache/incubator-weex/pull/572
modify WXValidateProcessor to make options params avalible
modify WXValidateProcessor and WXBridgeManager.etc to make options params avalible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/woshiaxie/incubator-weex 0.16-dev
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/572.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #572
----
commit e99a4ae4c3eb53590e70eccd0547d961ffacd4b7
Author: 墨笑 <sa...@alibaba-inc.com>
Date: 2017-08-03T12:37:22Z
pass options into validate process
commit 1fe7ab7f129677f7b90158f144e9a4248b35b018
Author: 墨笑 <sa...@alibaba-inc.com>
Date: 2017-08-03T14:36:09Z
add parent to domObject, when it is created
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #572: modify WXValidateProcessor to make options...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/572
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #572: modify WXValidateProcessor to make options params...
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/572
<!--
1 failure: This PR modify SD...
4 warning: No Changelog chan..., This PR should up..., Potential BREAK C..., Potential BREAK C...
1 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Fails</th>
</tr>
</thead>
<tbody><tr>
<td>:no_entry_sign:</td>
<td>This PR modify SDK code. Please add/modify corresponding testcases. If it is ok, please comment about it. Or put '@notdanger' in you commit message.</td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Warnings</th>
</tr>
</thead>
<tbody><tr>
<td>:warning:</td>
<td>No Changelog changes!</td>
</tr>
<tr>
<td>:warning:</td>
<td>This PR should update related documents as well. </td>
</tr>
<tr>
<td>:warning:</td>
<td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java without metion it in commit message. You'd better add '@notdanger' in your commit log. </td>
</tr>
<tr>
<td>:warning:</td>
<td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/dom/WXDomObject.java without metion it in commit message. You'd better add '@notdanger' in your commit log. </td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>According to the blame info, we recommended @168668660 , @zshshr to be the reviewers.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #572: modify WXValidateProcessor to make options...
Posted by zshshr <gi...@git.apache.org>.
Github user zshshr commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/572#discussion_r131306873
--- Diff: android/sdk/src/main/java/com/taobao/weex/dom/WXDomObject.java ---
@@ -627,7 +627,7 @@ public String dumpDomTree() {
* @param json the original JSONObject
* @return Dom Object corresponding to the JSONObject.
*/
- public static @Nullable WXDomObject parse(JSONObject json, WXSDKInstance wxsdkInstance){
--- End diff --
do not modify public method
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---