You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Navina Ramesh <nr...@linkedin.com> on 2015/11/25 00:13:08 UTC

Review Request 40678: SAMZA-820 - Separate checkpoint stream and coordinator stream configurations and update documentation

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40678/
-----------------------------------------------------------

Review request for samza, Boris Shkolnik, Yan Fang, Chris Riccomini, Jake Maes, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure).


Bugs: SAMZA-820
    https://issues.apache.org/jira/browse/SAMZA-820


Repository: samza


Description
-------

SAMZA-820 - Separate checkpoint stream and coordinator stream configurations and update documentation


Diffs
-----

  docs/learn/documentation/versioned/jobs/configuration-table.html 09f2b6f9d80b485af65724d94ebcdac03cded6bb 
  samza-core/src/main/scala/org/apache/samza/config/JobConfig.scala 85a1ca42bed8921880f7eb4b9665e7b5f2f8f139 

Diff: https://reviews.apache.org/r/40678/diff/


Testing
-------


Thanks,

Navina Ramesh


Re: Review Request 40678: SAMZA-820 - Separate checkpoint stream and coordinator stream configurations and update documentation

Posted by Navina Ramesh <nr...@linkedin.com>.

> On Nov. 24, 2015, 11:48 p.m., Yi Pan (Data Infrastructure) wrote:
> > LGTM. We can follow up w/ a JIRA to make the coordinator stream configurations as "required" independent configs later.

Yep. I agree. Thanks for the review!


- Navina


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40678/#review107876
-----------------------------------------------------------


On Nov. 24, 2015, 11:13 p.m., Navina Ramesh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40678/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2015, 11:13 p.m.)
> 
> 
> Review request for samza, Boris Shkolnik, Yan Fang, Chris Riccomini, Jake Maes, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure).
> 
> 
> Bugs: SAMZA-820
>     https://issues.apache.org/jira/browse/SAMZA-820
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> SAMZA-820 - Separate checkpoint stream and coordinator stream configurations and update documentation
> 
> 
> Diffs
> -----
> 
>   docs/learn/documentation/versioned/jobs/configuration-table.html 09f2b6f9d80b485af65724d94ebcdac03cded6bb 
>   samza-core/src/main/scala/org/apache/samza/config/JobConfig.scala 85a1ca42bed8921880f7eb4b9665e7b5f2f8f139 
> 
> Diff: https://reviews.apache.org/r/40678/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Navina Ramesh
> 
>


Re: Review Request 40678: SAMZA-820 - Separate checkpoint stream and coordinator stream configurations and update documentation

Posted by "Yi Pan (Data Infrastructure)" <yi...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40678/#review107876
-----------------------------------------------------------

Ship it!


LGTM. We can follow up w/ a JIRA to make the coordinator stream configurations as "required" independent configs later.

- Yi Pan (Data Infrastructure)


On Nov. 24, 2015, 11:13 p.m., Navina Ramesh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40678/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2015, 11:13 p.m.)
> 
> 
> Review request for samza, Boris Shkolnik, Yan Fang, Chris Riccomini, Jake Maes, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure).
> 
> 
> Bugs: SAMZA-820
>     https://issues.apache.org/jira/browse/SAMZA-820
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> SAMZA-820 - Separate checkpoint stream and coordinator stream configurations and update documentation
> 
> 
> Diffs
> -----
> 
>   docs/learn/documentation/versioned/jobs/configuration-table.html 09f2b6f9d80b485af65724d94ebcdac03cded6bb 
>   samza-core/src/main/scala/org/apache/samza/config/JobConfig.scala 85a1ca42bed8921880f7eb4b9665e7b5f2f8f139 
> 
> Diff: https://reviews.apache.org/r/40678/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Navina Ramesh
> 
>