[GitHub] [wicket] martin-g commented on a diff in pull request #517: WICKET-6963 Singleton markup sourcing strategy (Take 2)

[GitBox <gi...@apache.org>]

martin-g commented on code in PR #517:
URL: https://github.com/apache/wicket/pull/517#discussion_r859865225


##########
wicket-core/src/main/java/org/apache/wicket/markup/html/panel/PanelMarkupSourcingStrategy.java:
##########
@@ -33,9 +33,28 @@
  */
 public class PanelMarkupSourcingStrategy extends AssociatedMarkupSourcingStrategy
 {
+	private static final PanelMarkupSourcingStrategy PANEL_INSTANCE = new PanelMarkupSourcingStrategy(
+		false);
+	private static final PanelMarkupSourcingStrategy BORDER_INSTANCE = new PanelMarkupSourcingStrategy(
+		true);
+
 	// False for Panel and true for Border components.
 	private final boolean allowWicketComponentsInBodyMarkup;

Review Comment:
   Is it a good moment to re-work this boolean to an enum ?
   With an enum it would be possible to have a third/forth/... state if needed. And it is more clear than `true`/`false`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org