[jira] [Commented] (AURORA-1588) Unnecessary HealthCheckConfig endpoint warning

["Maxim Khutornenko (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AURORA-1588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15111756#comment-15111756 ] 

Maxim Khutornenko commented on AURORA-1588:
-------------------------------------------

BTW, this seems to be a general problem with out deprecation messaging. E.g. this warning also shows up all the time:
{noformat}
restart_threshold has been deprecated and will be removed in a future release
{noformat}

This is due to default values still applied in the config. A possible solution could be dropping defaults where possible. E.g. it's safe to drop default for the {{restart_threshold}} but not so for the HealthCheckConfig values as they are passed into the executor.

> Unnecessary HealthCheckConfig endpoint warning
> ----------------------------------------------
>
>                 Key: AURORA-1588
>                 URL: https://issues.apache.org/jira/browse/AURORA-1588
>             Project: Aurora
>          Issue Type: Bug
>          Components: Client
>            Reporter: Maxim Khutornenko
>            Priority: Minor
>              Labels: newbie
>
> The recent [health checker refactoring|https://reviews.apache.org/r/41428] added a new message:
> {noformat}
> WARNING: endpoint, expected_response, and expected_response_code are deprecated and will be removed
> in the next release. Please consult updated documentation.
> {noformat}
> This message always shows up even when users don't explicitly specify deprecated fields. It should only warn when the .aurora file contains HealthCheckConfig with any of the deprecated fields.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)