You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/11/23 13:54:37 UTC

[GitHub] [incubator-devlake] liangjingyang opened a new issue, #3800: [Bug][Pipeline] Download logs but dbt folder got

liangjingyang opened a new issue, #3800:
URL: https://github.com/apache/incubator-devlake/issues/3800

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/incubator-devlake/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### What happened
   
   
   Download logs but dbt folder got 
   
   ![81073124-3ebe-4d5b-a3a6-844f9a09b599](https://user-images.githubusercontent.com/2056705/203563816-f2e974bd-56f4-4c00-84bf-e4794c96307f.jpeg)
   
   ### What do you expect to happen
   
   Download pipeline logs correctly.
   
   ### How to reproduce
   
   Click the "Download Full Log" button of a failed pipeline.
   
   ### Anything else
   
   _No response_
   
   ### Version
   
   v0.14.2
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] keon94 commented on issue #3800: [Bug][Pipeline] Download logs but dbt folder got

Posted by GitBox <gi...@apache.org>.
keon94 commented on issue #3800:
URL: https://github.com/apache/incubator-devlake/issues/3800#issuecomment-1331577738

   @liangjingyang What's happening exactly when you try to download them?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] klesh commented on issue #3800: [Bug][Pipeline] Download logs but dbt folder got

Posted by GitBox <gi...@apache.org>.
klesh commented on issue #3800:
URL: https://github.com/apache/incubator-devlake/issues/3800#issuecomment-1326229999

   @keon94 Would you take a look at this? thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] mindlesscloud closed issue #3800: [Bug][Pipeline] Download logs but dbt folder got

Posted by GitBox <gi...@apache.org>.
mindlesscloud closed issue #3800: [Bug][Pipeline] Download logs but dbt folder got 
URL: https://github.com/apache/incubator-devlake/issues/3800


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] keon94 commented on issue #3800: [Bug][Pipeline] Download logs but dbt folder got

Posted by GitBox <gi...@apache.org>.
keon94 commented on issue #3800:
URL: https://github.com/apache/incubator-devlake/issues/3800#issuecomment-1334737963

   Also please check your LOGGING_DIR env. I suspect you might be sharing it with another directory that has all your dbt stuff.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] liangjingyang commented on issue #3800: [Bug][Pipeline] Download logs but dbt folder got

Posted by GitBox <gi...@apache.org>.
liangjingyang commented on issue #3800:
URL: https://github.com/apache/incubator-devlake/issues/3800#issuecomment-1336122104

   Hi @keon94 thanks for your investigating and reply.
   
   I didn't set LOGGING_DIR, so it is the default working directory I guess: `/app`. 
   
   Yes, I mount a `dbt` folder on `/app/dbt`, but the downloaded folder is not the `/app/dbt`, it's `/app/dbt/dbt/proejcts/datacenter`.
   
   After some debuging on `release-0.14`, I found that [here](https://github.com/apache/incubator-devlake/blob/release-v0.14/plugins/dbt/tasks/convertor.go#L58) changed the working directory which maybe made the logging directory changed.
   
   I have some suggestions for discussing:
   
   1. The dbt plugin shouldn't change the working directory @long2ice. (It's better not change the working directory in runtime ). 
   2. The core should give a unified base path for relative path.
   3. Consider to give a specific relative logging path as default LOGGING_DIR in .env, something like `logs`, since [here](https://github.com/apache/incubator-devlake/blob/release-v0.14/services/pipeline.go#L333) downloads the whole logging directory.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] keon94 commented on issue #3800: [Bug][Pipeline] Download logs but dbt folder got

Posted by GitBox <gi...@apache.org>.
keon94 commented on issue #3800:
URL: https://github.com/apache/incubator-devlake/issues/3800#issuecomment-1331577106

   Okay, will investigate this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] keon94 commented on issue #3800: [Bug][Pipeline] Download logs but dbt folder got

Posted by GitBox <gi...@apache.org>.
keon94 commented on issue #3800:
URL: https://github.com/apache/incubator-devlake/issues/3800#issuecomment-1334727931

   I tested this on a couple of plugins that errored out midway and did not run into any issues. The logs downloaded normally.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] keon94 commented on issue #3800: [Bug][Pipeline] Download logs but dbt folder got

Posted by GitBox <gi...@apache.org>.
keon94 commented on issue #3800:
URL: https://github.com/apache/incubator-devlake/issues/3800#issuecomment-1334728286

   @liangjingyang please share your full blueprint setup with me so I can replicate this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] klesh commented on issue #3800: [Bug][Pipeline] Download logs but dbt folder got

Posted by GitBox <gi...@apache.org>.
klesh commented on issue #3800:
URL: https://github.com/apache/incubator-devlake/issues/3800#issuecomment-1363672089

   1. fixed by #3976 
   2. fixed by #3863 
   3. will put up an pr for that 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org