You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@creadur.apache.org by "Dan Dumont (JIRA)" <ji...@apache.org> on 2015/02/16 21:33:12 UTC
[jira] [Comment Edited] (RAT-190) False negatives(?) in apache rat
license checking
[ https://issues.apache.org/jira/browse/RAT-190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14323245#comment-14323245 ]
Dan Dumont edited comment on RAT-190 at 2/16/15 8:32 PM:
---------------------------------------------------------
I've merged your pom into my zip and I'm uploading a new version.
You'll note that I did NOT add the correct copyright to the js file, so you should expect an error... yet..
>mvn -version
Apache Maven 3.0.5 (r01de14724cdef164cd33c7c8c2fe155faf9602da; 2013-02-19 08:51:28-0500)
Maven home: C:\apache-maven-3.0.5\bin\..
Java version: 1.7.0_21, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.7.0_21\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 8", version: "6.2", arch: "amd64", family: "windows"
[INFO]
[INFO] --- maven-jar-plugin:2.3.2:jar (default-jar) @ test ---
[WARNING] JAR will be empty - no content was marked for inclusion!
[INFO] Building jar: C:\Users\ddumont\Desktop\test\target\test-1.0-SNAPSHOT.jar
[INFO]
[INFO] --- apache-rat-plugin:0.11:check (default) @ test ---
[INFO] 51 implicit excludes (use -debug for more details).
[INFO] Exclude: *.loadrule
[INFO] Exclude: **/.*
[INFO] Exclude: **/.*/*
[INFO] Exclude: **/*.json
[INFO] Exclude: **/*.html
[INFO] Exclude: **/*.md
[INFO] Exclude: **/*.log
[INFO] Exclude: **/*.mf
[INFO] Exclude: src/site/**
[INFO] Exclude: src/scripts/**
[INFO] Exclude: *.obsolete/**
[INFO] Exclude: **/test/**
[INFO] Exclude: sequoia-crx/**
[INFO] Exclude: shimmer-cookie-ninja/**
[INFO] 2 resources included (use -debug for more details)
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 1 licence.
[INFO]
[INFO] --- maven-install-plugin:2.3.1:install (default-install) @ test ---
[INFO] Installing \test\target\test-1.0-SNAPSHOT.jar to \.m2\repository\com\mycompany\app\test\
1.0-SNAPSHOT\test-1.0-SNAPSHOT.jar
[INFO] Installing \test\pom.xml to \.m2\repository\com\mycompany\app\test\1.0-SNAPSHOT\test-1.0
-SNAPSHOT.pom
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 2.588s
[INFO] Finished at: Mon Feb 16 15:27:37 EST 2015
[INFO] Final Memory: 11M/151M
[INFO] ------------------------------------------------------------------------
was (Author: ddumont):
I've merged your pom into my zip and I'm uploading a new version.
You'll note that I did NOT add the correct copyright to the js file, so you should expect an error... yet..
````
>mvn -version
Apache Maven 3.0.5 (r01de14724cdef164cd33c7c8c2fe155faf9602da; 2013-02-19 08:51:28-0500)
Maven home: C:\apache-maven-3.0.5\bin\..
Java version: 1.7.0_21, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.7.0_21\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 8", version: "6.2", arch: "amd64", family: "windows"
````
[INFO]
[INFO] --- maven-jar-plugin:2.3.2:jar (default-jar) @ test ---
[WARNING] JAR will be empty - no content was marked for inclusion!
[INFO] Building jar: C:\Users\ddumont\Desktop\test\target\test-1.0-SNAPSHOT.jar
[INFO]
[INFO] --- apache-rat-plugin:0.11:check (default) @ test ---
[INFO] 51 implicit excludes (use -debug for more details).
[INFO] Exclude: *.loadrule
[INFO] Exclude: **/.*
[INFO] Exclude: **/.*/*
[INFO] Exclude: **/*.json
[INFO] Exclude: **/*.html
[INFO] Exclude: **/*.md
[INFO] Exclude: **/*.log
[INFO] Exclude: **/*.mf
[INFO] Exclude: src/site/**
[INFO] Exclude: src/scripts/**
[INFO] Exclude: *.obsolete/**
[INFO] Exclude: **/test/**
[INFO] Exclude: sequoia-crx/**
[INFO] Exclude: shimmer-cookie-ninja/**
[INFO] 2 resources included (use -debug for more details)
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 1 licence.
[INFO]
[INFO] --- maven-install-plugin:2.3.1:install (default-install) @ test ---
[INFO] Installing \test\target\test-1.0-SNAPSHOT.jar to \.m2\repository\com\mycompany\app\test\
1.0-SNAPSHOT\test-1.0-SNAPSHOT.jar
[INFO] Installing \test\pom.xml to \.m2\repository\com\mycompany\app\test\1.0-SNAPSHOT\test-1.0
-SNAPSHOT.pom
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 2.588s
[INFO] Finished at: Mon Feb 16 15:27:37 EST 2015
[INFO] Final Memory: 11M/151M
[INFO] ------------------------------------------------------------------------
> False negatives(?) in apache rat license checking
> -------------------------------------------------
>
> Key: RAT-190
> URL: https://issues.apache.org/jira/browse/RAT-190
> Project: Apache Rat
> Issue Type: Bug
> Affects Versions: 0.8, 0.11
> Reporter: Dan Dumont
> Assignee: Philipp Ottlinger
> Attachments: complete-pom.xml, test.zip
>
>
> We're using rat to enforce our internal copyright on all of our source files.
> We're seeing it missing files that should be flagged. Here's part of our pom:
> <licenses>
> <license implementation="org.apache.rat.analysis.license.SimplePatternBasedLicense">
> <licenseFamilyCategory>IBMCL</licenseFamilyCategory>
> <licenseFamilyName>IBM Copyright</licenseFamilyName>
> <notes></notes>
> <patterns>
> <pattern>Copyright IBM Corp. 2015</pattern>
> <pattern>Copyright IBM Corp. 2014, 2015</pattern>
> <pattern>Copyright IBM Corp. 2013, 2015</pattern>
> </patterns>
> </license>
> </licenses>
> <licenseFamilies>
> <licenseFamily implementation="org.apache.rat.license.SimpleLicenseFamily">
> <familyName>IBM Copyright</familyName>
> </licenseFamily>
> </licenseFamilies>
> The file in question is "included" as reported by running with debug output... but the file's copyright is:
> /* Copyright IBM Corp. 2014 All Rights Reserved. */
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)