You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/12/04 08:09:24 UTC
[GitHub] [rocketmq-client-go] sunday9th opened a new pull request #564: fix: error judgment can't hit export error type
sunday9th opened a new pull request #564:
URL: https://github.com/apache/rocketmq-client-go/pull/564
## What is the purpose of the change
error judgment can't hit export error type
```go
resp, err := pc.PullFrom(context.Background(), queue, offset, 1)
if err != nil {
if err == rocketmq.ErrRequestTimeout {
fmt.Printf("timeout \n")
time.Sleep(2 * time.Second)
continue
}
fmt.Printf("unexpectable err: %v \n", err)
return
}
```
`err == rocketmq.ErrRequestTimeout` never work
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] codecov-io commented on pull request #564: fix: error judgment can't hit export error type
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #564:
URL: https://github.com/apache/rocketmq-client-go/pull/564#issuecomment-738634892
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/564?src=pr&el=h1) Report
> Merging [#564](https://codecov.io/gh/apache/rocketmq-client-go/pull/564?src=pr&el=desc) (6c1b3fb) into [master](https://codecov.io/gh/apache/rocketmq-client-go/commit/4c35ae2578d01d420a29bb6ae03401bc59f48fdf?el=desc) (4c35ae2) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/rocketmq-client-go/pull/564?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #564 +/- ##
=======================================
Coverage 24.22% 24.22%
=======================================
Files 48 48
Lines 5011 5011
=======================================
Hits 1214 1214
Misses 3598 3598
Partials 199 199
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/564?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/564?src=pr&el=footer). Last update [4c35ae2...6c1b3fb](https://codecov.io/gh/apache/rocketmq-client-go/pull/564?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] sunday9th closed pull request #564: fix: error judgment can't hit export error type
Posted by GitBox <gi...@apache.org>.
sunday9th closed pull request #564:
URL: https://github.com/apache/rocketmq-client-go/pull/564
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] codecov-io edited a comment on pull request #564: fix: error judgment can't hit export error type
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #564:
URL: https://github.com/apache/rocketmq-client-go/pull/564#issuecomment-738634892
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/564?src=pr&el=h1) Report
> Merging [#564](https://codecov.io/gh/apache/rocketmq-client-go/pull/564?src=pr&el=desc) (6c1b3fb) into [master](https://codecov.io/gh/apache/rocketmq-client-go/commit/4c35ae2578d01d420a29bb6ae03401bc59f48fdf?el=desc) (4c35ae2) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/rocketmq-client-go/pull/564?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #564 +/- ##
=======================================
Coverage 24.22% 24.22%
=======================================
Files 48 48
Lines 5011 5011
=======================================
Hits 1214 1214
Misses 3598 3598
Partials 199 199
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/564?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/564?src=pr&el=footer). Last update [4c35ae2...6c1b3fb](https://codecov.io/gh/apache/rocketmq-client-go/pull/564?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org