You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/07/17 07:39:04 UTC

[jira] [Commented] (TAJO-914) join queries with constant values can cause schema mismatch in logical plan

    [ https://issues.apache.org/jira/browse/TAJO-914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14064593#comment-14064593 ] 

ASF GitHub Bot commented on TAJO-914:
-------------------------------------

GitHub user hyunsik opened a pull request:

    https://github.com/apache/tajo/pull/78

    TAJO-914: join queries with constant values can cause schema mismatch in logical plan

    This is a temporal solution, but it effectively fixes the critical problem.
    
    Its essential solution would be TAJO-895. Please see the detail at https://issues.apache.org/jira/browse/TAJO-914.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hyunsik/tajo TAJO-914

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/78.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #78
    
----
commit 3f47df51d1868e59f2de2c6b29d5d38b2b5cb5f6
Author: Hyunsik Choi <hy...@apache.org>
Date:   2014-07-07T04:39:05Z

    TAJO-913: Add some missed tests for constant value group-by keys.

commit 627967b2077dbd68a5401110b42ea04b4fddfeac
Author: Hyunsik Choi <hy...@apache.org>
Date:   2014-07-07T06:37:25Z

    Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-913

commit 9ef919dd12407865e0e83599893ac06cdb90b51a
Author: Hyunsik Choi <hy...@apache.org>
Date:   2014-07-08T03:17:55Z

    TAJO-914: join queries with constant values can cause schema mismatch in logical plan.

commit f016b57abd7ad265949c3bbb98d08fe8335738db
Author: Hyunsik Choi <hy...@apache.org>
Date:   2014-07-17T05:35:47Z

    Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-914
    
    Conflicts:
    	tajo-core/src/test/java/org/apache/tajo/engine/query/TestGroupByQuery.java
    	tajo-core/src/test/resources/queries/TestGroupByQuery/testGroupByWithConstantKeys2.sql
    	tajo-core/src/test/resources/results/TestGroupByQuery/testGroupByWithConstantKeys2.result

----


> join queries with constant values can cause schema mismatch in logical plan
> ---------------------------------------------------------------------------
>
>                 Key: TAJO-914
>                 URL: https://issues.apache.org/jira/browse/TAJO-914
>             Project: Tajo
>          Issue Type: Bug
>          Components: planner/optimizer
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>             Fix For: 0.9.0
>
>
> The following query can cause a schema mismatch problem between join node and its both child scan nodes. The main cause that '##' col1 are evaluated in both ScanNode. Because a schema cannot include the same column names, one col1 is omitted. So, it causes the schema mismatch problem.
> {noformat}
> select l_orderkey, '##' as col1 from lineitem join orders on l_orderkey = o_orderkey group by l_orderkey, col1
> {noformat}
> This is a critical bug. So, I've uploaded the urgent workaround bug fix. Later, I'll fix it in more valid and stable manner. I already created the Jira issue (TAJO-895) for that way.



--
This message was sent by Atlassian JIRA
(v6.2#6252)