[GitHub] storm pull request #2705: STORM-3096 prevent race condition during topology ...

[agresch <gi...@git.apache.org>]

GitHub user agresch opened a pull request:

    https://github.com/apache/storm/pull/2705

    STORM-3096 prevent race condition during topology submission

    My previous attempt at fixing this addressed the race in store.storedTopoIds().  But state.idsOfTopologiesWithPrivateWorkerKeys() will also return a topology as ready to clean up while the topology is being submitted.
    
    The fix is to delay deletion on all topologies found for all the state and store checks.
    
    I was able to reproduce the issue and validate the fix properly this time by forcing a Nimbus cleanup to be called as part of topology submission.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/agresch/storm agresch_blob2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2705.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2705
    
----
commit 8f60cefe4bd57f4d143f47e1b8862765abaad445
Author: Aaron Gresch <ag...@...>
Date:   2018-06-05T20:58:29Z

    STORM-3096 prevent race condition during topology submission

----


---

[GitHub] storm pull request #2705: STORM-3096 prevent race condition during topology ...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/2705


---