You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by "Peter Bacsko (JIRA)" <ji...@apache.org> on 2016/11/25 10:54:58 UTC
[jira] [Resolved] (OOZIE-2698) OYA: Refactor LauncherAM to make it
more testable
[ https://issues.apache.org/jira/browse/OOZIE-2698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Bacsko resolved OOZIE-2698.
---------------------------------
Resolution: Fixed
> OYA: Refactor LauncherAM to make it more testable
> -------------------------------------------------
>
> Key: OOZIE-2698
> URL: https://issues.apache.org/jira/browse/OOZIE-2698
> Project: Oozie
> Issue Type: Sub-task
> Reporter: Peter Bacsko
> Assignee: Peter Bacsko
>
> We should refactor the code in LauncherAM.
> Current problems with the code:
> - everything is static, main codepath is only reachable from the {{main()}} method
> - dependencies should either be injected or generated by a factory (this is the most important part)
> - class is moderately long (730-740), some of its parts could possibly be extracted to other classes
> - order of private/protected/public methods
> In its current form, it's not easy to provide a good test coverage for this class. Refactor it so that we can write more thorough unit tests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)