[jira] [Comment Edited] (THRIFT-5216) generate DeepCopy methods

["Jens Geyer (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-5216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17115597#comment-17115597 ] 

Jens Geyer edited comment on THRIFT-5216 at 5/24/20, 11:58 PM:
---------------------------------------------------------------

Found few other issues during test case creation, fixed them as well (unfortunately it's quite hard to make a separate patch of it)
 * union Equals() missing
 * TCollections.Equals() does not work for nested Container classes
 * TCollections.Equals() does not work for Dictionaries


was (Author: jensg):
Found few other issues furimng test case creation, fixed as well (unfortumnately it's quite hard to make a separate patch of it)

 * union Equals() missing
 * TCollections.Equals() does not work for nested Container classes 
 * TCollections.Equals() does not work for Dictionaries

> generate DeepCopy methods
> -------------------------
>
>                 Key: THRIFT-5216
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5216
>             Project: Thrift
>          Issue Type: Improvement
>          Components: netstd - Compiler
>            Reporter: Jens Geyer
>            Assignee: Jens Geyer
>            Priority: Major
>
> Frequently one runs into a need to create deep copies from Thrift data objects. Since the framework does not really offer support for such a function, it seems helpful to have the Thrift Comnpiler generate the code necessary to support this.
> Remarks:
>  * Microsoft explicitly discourages developeres to use ICloneable for this as there is no reliable definition whether ICloneable creates shallow or deep copies, so we don't use it either.
>  * Although there is no officially set standard, most common naming convention seems to be {{DeepCopy()}} for such a method, so we follow that model but leave room for future changes (i.e. different naming)
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)