[GitHub] [maven-ear-plugin] elharo commented on a change in pull request #31: [MEAR-294] Removal of provided artifacts from the Class-Path entry of MANIFEST.mf

[GitBox <gi...@apache.org>]

elharo commented on a change in pull request #31:
URL: https://github.com/apache/maven-ear-plugin/pull/31#discussion_r546435418



##########
File path: src/test/java/org/apache/maven/plugins/ear/it/EarMojoIT.java
##########
@@ -1003,8 +1003,12 @@ public void testProject091()
      * <li>skinnyModules options is turned on</li>
      * </ul>
      * then movement of JARs and modification of manifest Class-Path entry is performed for WAR, SAR, HAR and RAR
-     * modules. Additionally this test ensures that movement of JARs is not performed for modules which
-     * libDirectory property doesn't point to the right module entry containing JAR libraries packaged into module.
+     * modules. Additionally this test ensures that
+     * <ul>
+     * <li>movement of JARs is not performed for modules which libDirectory property doesn't point to correct module

Review comment:
       which --> whose
   to correct --> to the correct
   into module --> into the module

##########
File path: src/main/java/org/apache/maven/plugins/ear/AbstractEarMojo.java
##########
@@ -317,6 +325,18 @@ public void execute()
         return allJarModules;
     }
 
+    /**
+     * @return The list of {@link #providedJarModules}. This corresponds to provided JAR modules.

Review comment:
       The --> the




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org