You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2020/03/01 16:26:20 UTC
[GitHub] [cordova-plugin-inappbrowser] jcesarmobile opened a new pull
request #635: breaking: remove UIWebView
jcesarmobile opened a new pull request #635: breaking: remove UIWebView
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/635
Remove all UIWebView code and traces
- Removes all traces of UIWebView from README
- Removes al UIWebView code
- Removes usage of CDVUserAgentUtil as it's being removed from cordova-ios and it's not really needed for WKWebView
- Removes old cordova version code checks as it will only work on the next cordova-ios
- Removes suppressesincrementalrendering and keyboarddisplayrequiresuseraction as they were UIWebView only
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] jcesarmobile merged pull request
#635: breaking: remove UIWebView
Posted by GitBox <gi...@apache.org>.
jcesarmobile merged pull request #635: breaking: remove UIWebView
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/635
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] timbru31 commented on issue #635:
breaking: remove UIWebView
Posted by GitBox <gi...@apache.org>.
timbru31 commented on issue #635: breaking: remove UIWebView
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/635#issuecomment-612925477
Yes, but only in 4.0.0, as this is a breaking change. No ETA though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] jcesarmobile commented on issue #635:
breaking: remove UIWebView
Posted by GitBox <gi...@apache.org>.
jcesarmobile commented on issue #635: breaking: remove UIWebView
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/635#issuecomment-595268789
thanks for the reviews!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] tverilytt commented on issue #635:
breaking: remove UIWebView
Posted by GitBox <gi...@apache.org>.
tverilytt commented on issue #635: breaking: remove UIWebView
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/635#issuecomment-612994942
Thanks for that! To use this now then, one has to pull master branch, no npm install option yet?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] tverilytt commented on issue #635:
breaking: remove UIWebView
Posted by GitBox <gi...@apache.org>.
tverilytt commented on issue #635: breaking: remove UIWebView
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/635#issuecomment-612894826
Will it be included in next version (3.3.0?)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] NiklasMerz commented on issue #635:
breaking: remove UIWebView
Posted by GitBox <gi...@apache.org>.
NiklasMerz commented on issue #635: breaking: remove UIWebView
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/635#issuecomment-595256771
I did some basic tests. Looks good to me 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] timbru31 commented on issue #635:
breaking: remove UIWebView
Posted by GitBox <gi...@apache.org>.
timbru31 commented on issue #635: breaking: remove UIWebView
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/635#issuecomment-613006814
You can always use the unsupported master branch via git:
`cordova plugin add https://github.com/apache/cordova-plugin-inappbrowser.git`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org