You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2021/05/10 10:20:37 UTC
[GitHub] [cassandra] bereng opened a new pull request #1004: Fix typo
bereng opened a new pull request #1004:
URL: https://github.com/apache/cassandra/pull/1004
patch by Berenguer Blasi; reviewed by <Reviewers> for CASSANDRA-16661
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] ekaterinadimitrova2 commented on a change in pull request #1004: Fix typo
Posted by GitBox <gi...@apache.org>.
ekaterinadimitrova2 commented on a change in pull request #1004:
URL: https://github.com/apache/cassandra/pull/1004#discussion_r629394573
##########
File path: src/java/org/apache/cassandra/cql3/statements/schema/AlterTypeStatement.java
##########
@@ -193,7 +193,7 @@ private AlterField(String keyspaceName, String typeName)
UserType apply(KeyspaceMetadata keyspace, UserType userType)
{
- throw ire("Alterting field types is no longer supported");
Review comment:
Leave it as is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] bereng commented on a change in pull request #1004: Fix typo
Posted by GitBox <gi...@apache.org>.
bereng commented on a change in pull request #1004:
URL: https://github.com/apache/cassandra/pull/1004#discussion_r629389230
##########
File path: src/java/org/apache/cassandra/cql3/statements/schema/AlterTypeStatement.java
##########
@@ -193,7 +193,7 @@ private AlterField(String keyspaceName, String typeName)
UserType apply(KeyspaceMetadata keyspace, UserType userType)
{
- throw ire("Alterting field types is no longer supported");
Review comment:
I think 'is' is correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] bereng closed pull request #1004: Fix typo
Posted by GitBox <gi...@apache.org>.
bereng closed pull request #1004:
URL: https://github.com/apache/cassandra/pull/1004
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] ekaterinadimitrova2 commented on a change in pull request #1004: Fix typo
Posted by GitBox <gi...@apache.org>.
ekaterinadimitrova2 commented on a change in pull request #1004:
URL: https://github.com/apache/cassandra/pull/1004#discussion_r629315764
##########
File path: src/java/org/apache/cassandra/cql3/statements/schema/AlterTypeStatement.java
##########
@@ -193,7 +193,7 @@ private AlterField(String keyspaceName, String typeName)
UserType apply(KeyspaceMetadata keyspace, UserType userType)
{
- throw ire("Alterting field types is no longer supported");
Review comment:
While we are on this, can we also take care of the is/are issue, please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org