You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by "duan xiong (JIRA)" <ji...@apache.org> on 2019/01/15 13:36:00 UTC
[jira] [Comment Edited] (OOZIE-3417) [FS Action] Optimize code
about the command about chose fs action
[ https://issues.apache.org/jira/browse/OOZIE-3417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16742849#comment-16742849 ]
duan xiong edited comment on OOZIE-3417 at 1/15/19 1:35 PM:
------------------------------------------------------------
[~kmarton] Yes. I have tried but it failed. I can't login. Can you tell me how to register?Thank you very much.[~asalamon74] and [~gezapeti]
was (Author: nobigo):
[~kmarton] Yes. I have tried but it failed. I can't login. I try finding a way to login. Can you tell me how to login?Thank you very much.
> [FS Action] Optimize code about the command about chose fs action
> -----------------------------------------------------------------
>
> Key: OOZIE-3417
> URL: https://issues.apache.org/jira/browse/OOZIE-3417
> Project: Oozie
> Issue Type: Improvement
> Components: core
> Affects Versions: 5.2.0
> Reporter: duan xiong
> Assignee: duan xiong
> Priority: Major
> Labels: performance
> Attachments: oozie-3417-01.patch
>
>
> When I read FsActionExecutor.java, I found a not good code in this class. When judging which logic to use based on commands, should use "switch/case" replace "if/else":
> # “if/else” make the code hard to read
> # “if/else” make the code hard to extend
> # “if/else” has low efficience
> So I suggest using “switch/case” instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)