You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Hunt (Created) (JIRA)" <ji...@apache.org> on 2012/01/27 02:39:40 UTC
[jira] [Created] (ZOOKEEPER-1376) zkServer.sh does not correctly
check for $SERVER_JVMFLAGS
zkServer.sh does not correctly check for $SERVER_JVMFLAGS
---------------------------------------------------------
Key: ZOOKEEPER-1376
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1376
Project: ZooKeeper
Issue Type: Bug
Components: scripts
Affects Versions: 3.3.3
Reporter: Patrick Hunt
Priority: Minor
It will always include it even if not defined, although not much harm.
if [ "x$SERVER_JVMFLAGS" ]
then
JVMFLAGS="$SERVER_JVMFLAGS $JVMFLAGS"
fi
should use the std idiom.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (ZOOKEEPER-1376) zkServer.sh does not correctly
check for $SERVER_JVMFLAGS
Posted by "Henry Robinson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henry Robinson reassigned ZOOKEEPER-1376:
-----------------------------------------
Assignee: Skye Wanderman-Milne
> zkServer.sh does not correctly check for $SERVER_JVMFLAGS
> ---------------------------------------------------------
>
> Key: ZOOKEEPER-1376
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1376
> Project: ZooKeeper
> Issue Type: Bug
> Components: scripts
> Affects Versions: 3.3.3, 3.3.4
> Reporter: Patrick Hunt
> Assignee: Skye Wanderman-Milne
> Priority: Minor
> Labels: newbie
> Fix For: 3.3.7, 3.4.5
>
> Attachments: ZOOKEEPER-1376.patch
>
>
> It will always include it even if not defined, although not much harm.
> if [ "x$SERVER_JVMFLAGS" ]
> then
> JVMFLAGS="$SERVER_JVMFLAGS $JVMFLAGS"
> fi
> should use the std idiom.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1376) zkServer.sh does not correctly
check for $SERVER_JVMFLAGS
Posted by "Henry Robinson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henry Robinson updated ZOOKEEPER-1376:
--------------------------------------
Fix Version/s: 3.4.5
3.3.7
> zkServer.sh does not correctly check for $SERVER_JVMFLAGS
> ---------------------------------------------------------
>
> Key: ZOOKEEPER-1376
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1376
> Project: ZooKeeper
> Issue Type: Bug
> Components: scripts
> Affects Versions: 3.3.3, 3.3.4
> Reporter: Patrick Hunt
> Priority: Minor
> Labels: newbie
> Fix For: 3.3.7, 3.4.5
>
> Attachments: ZOOKEEPER-1376.patch
>
>
> It will always include it even if not defined, although not much harm.
> if [ "x$SERVER_JVMFLAGS" ]
> then
> JVMFLAGS="$SERVER_JVMFLAGS $JVMFLAGS"
> fi
> should use the std idiom.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1376) zkServer.sh does not correctly
check for $SERVER_JVMFLAGS
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13460909#comment-13460909 ]
Hadoop QA commented on ZOOKEEPER-1376:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12546108/ZOOKEEPER-1376.patch
against trunk revision 1386496.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1185//console
This message is automatically generated.
> zkServer.sh does not correctly check for $SERVER_JVMFLAGS
> ---------------------------------------------------------
>
> Key: ZOOKEEPER-1376
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1376
> Project: ZooKeeper
> Issue Type: Bug
> Components: scripts
> Affects Versions: 3.3.3, 3.3.4
> Reporter: Patrick Hunt
> Priority: Minor
> Labels: newbie
> Fix For: 3.3.7, 3.4.5
>
> Attachments: ZOOKEEPER-1376.patch
>
>
> It will always include it even if not defined, although not much harm.
> if [ "x$SERVER_JVMFLAGS" ]
> then
> JVMFLAGS="$SERVER_JVMFLAGS $JVMFLAGS"
> fi
> should use the std idiom.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1376) zkServer.sh does not correctly
check for $SERVER_JVMFLAGS
Posted by "Henry Robinson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13460911#comment-13460911 ]
Henry Robinson commented on ZOOKEEPER-1376:
-------------------------------------------
+1, patch looks good to me. I'll commit shortly to 3.3 and 3.4.
> zkServer.sh does not correctly check for $SERVER_JVMFLAGS
> ---------------------------------------------------------
>
> Key: ZOOKEEPER-1376
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1376
> Project: ZooKeeper
> Issue Type: Bug
> Components: scripts
> Affects Versions: 3.3.3, 3.3.4
> Reporter: Patrick Hunt
> Priority: Minor
> Labels: newbie
> Fix For: 3.3.7, 3.4.5
>
> Attachments: ZOOKEEPER-1376.patch
>
>
> It will always include it even if not defined, although not much harm.
> if [ "x$SERVER_JVMFLAGS" ]
> then
> JVMFLAGS="$SERVER_JVMFLAGS $JVMFLAGS"
> fi
> should use the std idiom.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1376) zkServer.sh does not correctly
check for $SERVER_JVMFLAGS
Posted by "Skye Wanderman-Milne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Skye Wanderman-Milne updated ZOOKEEPER-1376:
--------------------------------------------
Attachment: ZOOKEEPER-1376.patch
> zkServer.sh does not correctly check for $SERVER_JVMFLAGS
> ---------------------------------------------------------
>
> Key: ZOOKEEPER-1376
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1376
> Project: ZooKeeper
> Issue Type: Bug
> Components: scripts
> Affects Versions: 3.3.3, 3.3.4
> Reporter: Patrick Hunt
> Priority: Minor
> Labels: newbie
> Attachments: ZOOKEEPER-1376.patch
>
>
> It will always include it even if not defined, although not much harm.
> if [ "x$SERVER_JVMFLAGS" ]
> then
> JVMFLAGS="$SERVER_JVMFLAGS $JVMFLAGS"
> fi
> should use the std idiom.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira