You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/05 07:43:07 UTC

[GitHub] [flink] aljoscha commented on pull request #13530: [FLINK-19123] Use shared MiniCluster for executeAsync() in TestStreamEnvironment

aljoscha commented on pull request #13530:
URL: https://github.com/apache/flink/pull/13530#issuecomment-703460832


   Thanks for the review! I changed the boolean to an enum but I'm not sure about the naming, so very open to any suggestion.
   
   About formatting: I use the Google Java Style as the `google-java-format` tool applies but with tabs instead of spaces. That one consistently uses 2 levels of indentation for both arguments and parameters and continuation while using 1 level of indentation for blocks. I like how it visually makes arguments more distinct from code blocks and the internal consistency. Plus, it's compatible with our Checkstyle rules. I would prefer if we had a consistent code style that is enforceable and can automatically be applied but while we don't have that I'll use a style I like in new code that is compatible with our rules. Sorry for the longer block of text. 😅 I can still undo the whitespace changes here.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org