[jira] [Commented] (FELIX-4582) [Core R6] Support WovenClassListener

["Bob Paulin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FELIX-4582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14213318#comment-14213318 ] 

Bob Paulin commented on FELIX-4582:
-----------------------------------

Looks like the changes here are in BundleWiringImpl.findClass method.  It looks like the state transitions are not yet implemented for the WovenClass class so it seems like those will need to be added.  Additionally there appears to be exception handling on the transform of the class where the listener calls could be added.  However I'm not seeing very clear exception handling in the Define stage.  Any thoughts on what the define stage exception handling should look like?  The spec mentions we flip the state to DEFINE_FAILED if a class definition exception occurs but I don't see any specific code around this currently.  Last this method is quite large and probably could benefit from being broken up for readability.  Any concerns with breaking it up?

> [Core R6] Support WovenClassListener
> ------------------------------------
>
>                 Key: FELIX-4582
>                 URL: https://issues.apache.org/jira/browse/FELIX-4582
>             Project: Felix
>          Issue Type: Sub-task
>          Components: Framework
>            Reporter: David Bosschaert
>            Assignee: Bob Paulin
>             Fix For: framework-4.6.0
>
>
> The {{WovenClassListener}} is an enhancement of the weaving hooks. See chapter 56 of the Core R6 spec for details.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)