You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by canselcik <gi...@git.apache.org> on 2015/11/20 21:24:37 UTC
[GitHub] trafficserver pull request: Refactoring of atscppapi code
GitHub user canselcik opened a pull request:
https://github.com/apache/trafficserver/pull/344
Refactoring of atscppapi code
@bgaff
Removing `CaseInsensitiveStringComparator` class from `atscppapi` as it can be replaced with and is not used in the codebase at all.
Making sure `atscppapi` code includes `cinttypes` instead of `inttypes.h` and opting for the use of `string::assign()` rather than creating a new string and using `operator=()` on the old one.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/canselcik/trafficserver cppapi-minor
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/344.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #344
----
commit 36196e4d46d1cb2063719cee89bd92f4535ebd97
Author: Can Selcik <cs...@linkedin.com>
Date: 2015-11-20T20:02:01Z
Removing CaseInsensitiveStringComparator class from atscppapi as it can be replaced with and is not used in the codebase at all.
commit 0a1cd1ac7e6f78c01eeb49a532443728a94a9ad8
Author: Can Selcik <cs...@linkedin.com>
Date: 2015-11-20T20:05:23Z
Making sure atscppapi code includes cinttypes instead of inttypes.h and opting for the use of string.assign()...
method rather than creating a new string and using operator=() on the old one.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: Refactoring of atscppapi code
Posted by canselcik <gi...@git.apache.org>.
Github user canselcik closed the pull request at:
https://github.com/apache/trafficserver/pull/344
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: Refactoring of atscppapi code
Posted by bgaff <gi...@git.apache.org>.
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/344#issuecomment-158515283
I already have these changes locally that I'm about to commit you can close this pull request
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: Refactoring of atscppapi code
Posted by canselcik <gi...@git.apache.org>.
Github user canselcik commented on the pull request:
https://github.com/apache/trafficserver/pull/344#issuecomment-158515997
Sounds good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---