You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2021/04/29 02:17:33 UTC

[GitHub] [kylin] hit-lacus edited a comment on pull request #1596: [KYLIN-4780] Support dingtalk notify

hit-lacus edited a comment on pull request #1596:
URL: https://github.com/apache/kylin/pull/1596#issuecomment-828891154


     I wish this patch could be well designed for extensible purpose, and a **notification framework** should be developed from my side. 
     So, if other guys want to add support for We-chat or Slack, it should be very easy because he/her should only provided some implementation depend on this **notification framework** .
   
     I found that you provided a simple framework with some base classes : `NotifyServiceBase`, `NotificationContext`, `NotificationTransmitter`. I am not really sure if it is enough extensible. What do you think ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org