You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/16 11:12:45 UTC
[GitHub] [flink] tillrohrmann commented on a change in pull request #10863:
[FLINK-15598][yarn] Memory accuracy loss in YarnClusterDescriptor may lead
to deployment failure.
tillrohrmann commented on a change in pull request #10863: [FLINK-15598][yarn] Memory accuracy loss in YarnClusterDescriptor may lead to deployment failure.
URL: https://github.com/apache/flink/pull/10863#discussion_r367360336
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java
##########
@@ -785,15 +783,6 @@ private ApplicationReport startAppMaster(
paths.add(remotePathJar);
classPathBuilder.append(flinkJarPath.getName()).append(File.pathSeparator);
- // set the right configuration values for the TaskManager
- configuration.setInteger(
- TaskManagerOptions.NUM_TASK_SLOTS,
- clusterSpecification.getSlotsPerTaskManager());
-
- configuration.set(
- TaskManagerOptions.TOTAL_PROCESS_MEMORY,
- MemorySize.parse(clusterSpecification.getTaskManagerMemoryMB() + "m"));
Review comment:
I think we could change `YarnClusterDecriptor#validateClusterResources` to return a `ClusterSpecification` with the `taskManagerMemoryMB` of the passed in `ClusterSpecification`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services