You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/09/07 11:25:31 UTC

[GitHub] [shardingsphere] azexcy commented on a diff in pull request #20849: Extract pipeline meta data node change listener SPI for common usage

azexcy commented on code in PR #20849:
URL: https://github.com/apache/shardingsphere/pull/20849#discussion_r964724894


##########
shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-core/src/main/java/org/apache/shardingsphere/data/pipeline/core/execute/PipelineJobExecutor.java:
##########
@@ -81,9 +63,18 @@ private static void dispatchEvent(final DataChangedEvent event) {
                     log.error("analyze job config pojo failed.", ex);
                     return;
                 }
-                entry.getValue().handler(event, jobConfigPOJO);
+                entry.getValue().handle(event, jobConfigPOJO);
                 return;
             }
         }
     }
+    
+    /**
+     * Get pipeline job executor instance.
+     *
+     * @return pipeline job executor
+     */
+    public static PipelineJobExecutor getInstance() {
+        return INSTANCE;
+    }

Review Comment:
   Can't put it after `INSTANCE `, because must after `private Constructor`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org