You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eagle.apache.org by haoch <gi...@git.apache.org> on 2015/12/14 09:36:55 UTC

[GitHub] incubator-eagle pull request: EAGLE-66. Typesafe Streaming DSL and...

GitHub user haoch opened a pull request:

    https://github.com/apache/incubator-eagle/pull/26

    EAGLE-66. Typesafe Streaming DSL and KeyValue based Grouping

    https://issues.apache.org/jira/browse/EAGLE-66

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/haoch/incubator-eagle EAGLE-66

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-eagle/pull/26.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #26
    
----
commit 2d7003dd1200a500b329a518d63484600e1c2cdf
Author: Hao Chen <ha...@apache.org>
Date:   2015-12-02T16:28:58Z

    [EAGLE-66] Keep type information in StreamProcessor

commit e3389cdd52f7f747db0968d9e233e4184b99f5ff
Author: Hao Chen <ha...@apache.org>
Date:   2015-12-04T09:25:39Z

    [EAGLE-66] Decouple StreamProtocol and StreamProducer

commit e419ff886316bd536aa3c23aa337e51fa27a8c01
Author: Hao Chen <ha...@apache.org>
Date:   2015-12-04T13:33:21Z

    [EAGLE-66] Decouple execution environment and config

commit 8b2d7a64f3f600cf49204cd5abff762e70e8791e
Author: Hao Chen <ha...@apache.org>
Date:   2015-12-04T17:10:32Z

    [EAGLE-66] Simplify the stream processing API and configuration

commit 66abc2283092e04cb866b1280d1a286a14b3e117
Author: Hao Chen <ha...@apache.org>
Date:   2015-12-04T17:25:39Z

    [EAGLE-66] Refactor AbstractStormSpoutProvider from abstract class to interface StormSpoutProvider

commit 5b50c3fdb457f7f70f1654c8b19dcb1dae08b1cf
Author: Hao Chen <ha...@apache.org>
Date:   2015-12-04T18:18:14Z

    [EAGLE-66] Decouple ExecutionEnvironments factory functions

commit 5ca63dfa0fd755f008970cfa46dafdf5ac89dc29
Author: Hao Chen <ha...@apache.org>
Date:   2015-12-04T18:20:54Z

    [EAGLE-66] Rename ConfigWrapper to Configurator

commit f61fde9513de0e65dab7c22cd7f1552022764f58
Author: Hao Chen <ha...@apache.org>
Date:   2015-12-04T19:15:45Z

    [EAGLE-66] Refactor StreamProtocol `withName` to `as` interface

commit fbc234473d67d75aeece3c8f2d8963b93f11b3a0
Author: Hao Chen <ha...@apache.org>
Date:   2015-12-05T22:19:17Z

    [EAGLE-66] Basically workable key-value stream processing API

commit c20bfa141d5db4fd64790db87e7980c05984e671
Author: Hao Chen <ha...@apache.org>
Date:   2015-12-06T07:24:26Z

    [EAGLE-66] Simplify DAG structure log

commit a0ca7fa15088aded4f06eec8ab44bc2cacbb699c
Author: Hao Chen <ha...@apache.org>
Date:   2015-12-06T08:27:53Z

    [EAGLE-66] Implement from(Iterable) to replace fromSeq(Seq)

commit 69e68746520ca4648b3987f46d30acc6d6ced79a
Author: Hao Chen <ha...@apache.org>
Date:   2015-12-06T10:04:05Z

    [EAGLE-66] Clean DAG graph log

commit 7a6a13636ace590c148fc5793893d88b580e1f45
Author: Hao Chen <ha...@apache.org>
Date:   2015-12-06T17:54:33Z

    [EAGLE-66] Keep entity type info through dataflow and resolve scala/java compatibility issues

commit 9d7b8ceaa6b0b75b132e319da9b6efa5d0f164e1
Author: Hao Chen <ha...@apache.org>
Date:   2015-12-07T07:18:24Z

    [EAGLE-66] Refactored the package of datastream API

commit 26f6646f745ea4760f7934fb338d4b66a9c31510
Author: Hao Chen <ha...@apache.org>
Date:   2015-12-07T14:52:35Z

    [EAGLE-66] Support init/reinit method for StreamInfo to extensibly resolve issues like serialization/type and so on

commit 6fb171071a8f09223fd2757b1912bc52e1d4551d
Author: Hao Chen <ha...@apache.org>
Date:   2015-12-07T17:17:35Z

    [EAGLE-66] Support type for JavaFlatMap

commit c90efc0d34b7156d239a315f115064dc4c15bda9
Author: Hao Chen <ha...@apache.org>
Date:   2015-12-08T12:24:24Z

    [EAGLE-66] Fix DAG name and log printing

commit fd11d063896d00de40d06a33030f6be8fa85b881
Author: Hao Chen <ha...@apache.org>
Date:   2015-12-08T14:16:41Z

    [EAGLE-66] Resolve JavaTypeCompatible and add StreamTypeExpansion

commit 3b52a02c73e4a4651fd719103d78ea7566d6340b
Author: Hao Chen <ha...@apache.org>
Date:   2015-12-14T06:46:12Z

    EAGLE-66. Erase type information and fix hashCode problem for id

commit 9cc8f996fc885dec6d856e965a92185c5a78286a
Author: Hao Chen <ha...@apache.org>
Date:   2015-12-14T08:32:07Z

    EAGLE-66. Merge conflicts from master and support dot digraph
    
    Conflicts:
    	eagle-core/eagle-data-process/eagle-stream-process-api/src/main/scala/org/apache/eagle/datastream/StreamProducer.scala
    	eagle-core/eagle-data-process/eagle-stream-process-api/src/main/scala/org/apache/eagle/datastream/core/StreamAlertExpansion.scala
    	eagle-core/eagle-data-process/eagle-stream-process-api/src/test/scala/org/apache/eagle/datastream/TestDAGExpansion.scala
    	eagle-security/eagle-security-hdfs-auditlog/src/main/java/org/apache/eagle/security/auditlog/HdfsAuditLogProcessorMain.java

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request: EAGLE-66. Typesafe Streaming DSL and...

Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on the pull request:

    https://github.com/apache/incubator-eagle/pull/26#issuecomment-164402383
  
    Closes #27.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request: EAGLE-66. Typesafe Streaming DSL and...

Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on a diff in the pull request:

    https://github.com/apache/incubator-eagle/pull/26#discussion_r47479129
  
    --- Diff: eagle-core/eagle-data-process/eagle-stream-process-api/src/main/java/org/apache/eagle/datastream/utils/JavaReflections.java ---
    @@ -0,0 +1,15 @@
    +package org.apache.eagle.datastream.utils;
    --- End diff --
    
    Thanks and will fix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request: EAGLE-66. Typesafe Streaming DSL and...

Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on the pull request:

    https://github.com/apache/incubator-eagle/pull/26#issuecomment-164402151
  
    @RalphSu fixed missing license, please review again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request: EAGLE-66 Typesafe Streaming DSL and ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-eagle/pull/26


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request: EAGLE-66. Typesafe Streaming DSL and...

Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on the pull request:

    https://github.com/apache/incubator-eagle/pull/26#issuecomment-164434239
  
    @RalphSu thanks for reviewing. Could anyone else please help review as well? (Before Dec 15th, 2015)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request: EAGLE-66. Typesafe Streaming DSL and...

Posted by RalphSu <gi...@git.apache.org>.
Github user RalphSu commented on a diff in the pull request:

    https://github.com/apache/incubator-eagle/pull/26#discussion_r47477380
  
    --- Diff: eagle-core/eagle-data-process/eagle-stream-process-api/src/test/java/org/apache/eagle/datastream/TestExecutionEnvironmentJava.java ---
    @@ -0,0 +1,25 @@
    +package org.apache.eagle.datastream;
    --- End diff --
    
    Same as above, we need to add templates/formatter in code base.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request: EAGLE-66. Typesafe Streaming DSL and...

Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on a diff in the pull request:

    https://github.com/apache/incubator-eagle/pull/26#discussion_r47479151
  
    --- Diff: eagle-core/eagle-data-process/eagle-stream-process-api/src/test/java/org/apache/eagle/datastream/TestJavaReflectionUtils.java ---
    @@ -0,0 +1,19 @@
    +package org.apache.eagle.datastream;
    --- End diff --
    
    Thanks and will fix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request: EAGLE-66. Typesafe Streaming DSL and...

Posted by RalphSu <gi...@git.apache.org>.
Github user RalphSu commented on a diff in the pull request:

    https://github.com/apache/incubator-eagle/pull/26#discussion_r47477623
  
    --- Diff: eagle-core/eagle-data-process/eagle-stream-process-api/src/test/scala/org/apache/eagle/datastream/TestExecutionEnvironment.scala ---
    @@ -0,0 +1,17 @@
    +package org.apache.eagle.datastream
    --- End diff --
    
    +1 license


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request: EAGLE-66. Typesafe Streaming DSL and...

Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on a diff in the pull request:

    https://github.com/apache/incubator-eagle/pull/26#discussion_r47480905
  
    --- Diff: eagle-core/eagle-data-process/eagle-stream-process-api/src/test/java/org/apache/eagle/datastream/TestExecutionEnvironmentJava.java ---
    @@ -0,0 +1,25 @@
    +package org.apache.eagle.datastream;
    --- End diff --
    
    Fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request: EAGLE-66. Typesafe Streaming DSL and...

Posted by RalphSu <gi...@git.apache.org>.
Github user RalphSu commented on a diff in the pull request:

    https://github.com/apache/incubator-eagle/pull/26#discussion_r47481029
  
    --- Diff: eagle-core/eagle-data-process/eagle-stream-process-api/src/test/java/org/apache/eagle/datastream/TestExecutionEnvironmentJava.java ---
    @@ -0,0 +1,25 @@
    +package org.apache.eagle.datastream;
    --- End diff --
    
    http://creadur.apache.org/rat/apache-rat-plugin/rat-mojo.html  I think this might help.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request: EAGLE-66. Typesafe Streaming DSL and...

Posted by RalphSu <gi...@git.apache.org>.
Github user RalphSu commented on the pull request:

    https://github.com/apache/incubator-eagle/pull/26#issuecomment-164410901
  
    Looks good 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request: EAGLE-66. Typesafe Streaming DSL and...

Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on a diff in the pull request:

    https://github.com/apache/incubator-eagle/pull/26#discussion_r47479054
  
    --- Diff: eagle-core/eagle-data-process/eagle-stream-process-api/src/test/java/org/apache/eagle/datastream/TestExecutionEnvironmentJava.java ---
    @@ -0,0 +1,25 @@
    +package org.apache.eagle.datastream;
    --- End diff --
    
    https://github.com/apache/incubator-eagle/blob/master/pom.xml#L774-L781



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request: EAGLE-66. Typesafe Streaming DSL and...

Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on a diff in the pull request:

    https://github.com/apache/incubator-eagle/pull/26#discussion_r47478947
  
    --- Diff: eagle-core/eagle-data-process/eagle-stream-process-api/src/test/java/org/apache/eagle/datastream/TestExecutionEnvironmentJava.java ---
    @@ -0,0 +1,25 @@
    +package org.apache.eagle.datastream;
    --- End diff --
    
    Thanks for the review and I will fix them.
    
    I have integrated: http://creadur.apache.org/rat/apache-rat-plugin/
    We should make sure passing RAT checking in the CI environment:
        
        mvn apache-rat:check
    
    before merging any pull request.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request: EAGLE-66. Typesafe Streaming DSL and...

Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on a diff in the pull request:

    https://github.com/apache/incubator-eagle/pull/26#discussion_r47480491
  
    --- Diff: eagle-core/eagle-data-process/eagle-stream-process-api/src/test/java/org/apache/eagle/datastream/TestExecutionEnvironmentJava.java ---
    @@ -0,0 +1,25 @@
    +package org.apache.eagle.datastream;
    --- End diff --
    
    Only problem is that we currently still have some files like sample input data and font files can't pass the standard easily. :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request: EAGLE-66. Typesafe Streaming DSL and...

Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on a diff in the pull request:

    https://github.com/apache/incubator-eagle/pull/26#discussion_r47480887
  
    --- Diff: eagle-core/eagle-data-process/eagle-stream-process-api/src/main/java/org/apache/eagle/datastream/utils/JavaReflections.java ---
    @@ -0,0 +1,15 @@
    +package org.apache.eagle.datastream.utils;
    --- End diff --
    
    Fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request: EAGLE-66. Typesafe Streaming DSL and...

Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on a diff in the pull request:

    https://github.com/apache/incubator-eagle/pull/26#discussion_r47480941
  
    --- Diff: eagle-core/eagle-data-process/eagle-stream-process-api/src/test/scala/org/apache/eagle/datastream/TestExecutionEnvironment.scala ---
    @@ -0,0 +1,17 @@
    +package org.apache.eagle.datastream
    --- End diff --
    
    Fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request: EAGLE-66 Typesafe Streaming DSL and ...

Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on the pull request:

    https://github.com/apache/incubator-eagle/pull/26#issuecomment-165007280
  
    Merged


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request: EAGLE-66. Typesafe Streaming DSL and...

Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on a diff in the pull request:

    https://github.com/apache/incubator-eagle/pull/26#discussion_r47496505
  
    --- Diff: test.txt ---
    @@ -1 +0,0 @@
    -test for keep file for user command reassembler
    --- End diff --
    
    I remove test.txt here, dose anyone know why should we keep this file under code base root?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request: EAGLE-66. Typesafe Streaming DSL and...

Posted by RalphSu <gi...@git.apache.org>.
Github user RalphSu commented on a diff in the pull request:

    https://github.com/apache/incubator-eagle/pull/26#discussion_r47477062
  
    --- Diff: eagle-core/eagle-data-process/eagle-stream-process-api/src/main/java/org/apache/eagle/datastream/utils/JavaReflections.java ---
    @@ -0,0 +1,15 @@
    +package org.apache.eagle.datastream.utils;
    --- End diff --
    
    Missing license?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request: EAGLE-66. Typesafe Streaming DSL and...

Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on a diff in the pull request:

    https://github.com/apache/incubator-eagle/pull/26#discussion_r47480922
  
    --- Diff: eagle-core/eagle-data-process/eagle-stream-process-api/src/test/java/org/apache/eagle/datastream/TestJavaReflectionUtils.java ---
    @@ -0,0 +1,19 @@
    +package org.apache.eagle.datastream;
    --- End diff --
    
    Fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request: EAGLE-66. Typesafe Streaming DSL and...

Posted by RalphSu <gi...@git.apache.org>.
Github user RalphSu commented on a diff in the pull request:

    https://github.com/apache/incubator-eagle/pull/26#discussion_r47477417
  
    --- Diff: eagle-core/eagle-data-process/eagle-stream-process-api/src/test/java/org/apache/eagle/datastream/TestJavaReflectionUtils.java ---
    @@ -0,0 +1,19 @@
    +package org.apache.eagle.datastream;
    --- End diff --
    
    +1 for license missing


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request: EAGLE-66. Typesafe Streaming DSL and...

Posted by RalphSu <gi...@git.apache.org>.
Github user RalphSu commented on a diff in the pull request:

    https://github.com/apache/incubator-eagle/pull/26#discussion_r47480194
  
    --- Diff: eagle-core/eagle-data-process/eagle-stream-process-api/src/test/java/org/apache/eagle/datastream/TestExecutionEnvironmentJava.java ---
    @@ -0,0 +1,25 @@
    +package org.apache.eagle.datastream;
    --- End diff --
    
    Cool tool, we might doc this at contributing page.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request: EAGLE-66. Typesafe Streaming DSL and...

Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on a diff in the pull request:

    https://github.com/apache/incubator-eagle/pull/26#discussion_r47479158
  
    --- Diff: eagle-core/eagle-data-process/eagle-stream-process-api/src/test/scala/org/apache/eagle/datastream/TestExecutionEnvironment.scala ---
    @@ -0,0 +1,17 @@
    +package org.apache.eagle.datastream
    --- End diff --
    
    Thanks and will fix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---