[jira] [Commented] (WHIMSY-189) ASF::Board::Agenda.parse(..., true) inconsistent parsing of attendees

["Sam Ruby (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WHIMSY-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16422658#comment-16422658 ] 

Sam Ruby commented on WHIMSY-189:
---------------------------------

+1

> ASF::Board::Agenda.parse(..., true) inconsistent parsing of attendees
> ---------------------------------------------------------------------
>
>                 Key: WHIMSY-189
>                 URL: https://issues.apache.org/jira/browse/WHIMSY-189
>             Project: Whimsy
>          Issue Type: Bug
>          Components: BoardAgenda
>            Reporter: Shane Curcuru
>            Priority: Major
>
> ASF::Board::Agenda.parse(File.read('/foundation/board/archived_agendas/board_agenda_2008_08_20.txt', false)) only reports 8 people attending in [1]['people'], even though there were 11 people at the meeting.  This is inconsistent with quick=true, which reports everyone (albeit with __Underscore__Names instead of LDAP ids).
> Proposed fix in agenda/front.rb:
> {code:java}
> if @quick
> attr['people']['_' + name.gsub(/\W/, '_')] = {
> # Fillin hash with _Underscore_Name from actual text
> }
> else
> # look up name
> search = ASF::Person.list("cn=#{name}")
> # if found, save results in the attributes
> if search.length == 1
> person = search.first
> attr['people'][person.id] = {
> #Fillin hash from LDAP
> }
> end
> else
> # ADD: if LDAP name not found, fallback to "Fillin hash with _Underscore_Name from actual text" so that all people are added
> end
> end
> {code}
> Note: this changes the behavior for quick=false, returning a mixed hash of 'availid'=>... and '_Not_Found_Name'=>... entries.  But it feels better than silently dropping entries.
> Concerns before I fix this?
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)