You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/08/31 15:48:18 UTC

[GitHub] [hbase] bharathv commented on a change in pull request #2323: [HBASE-24957] ZKTableStateClientSideReader#isDisabledTable doesn't check if table exists or not.

bharathv commented on a change in pull request #2323:
URL: https://github.com/apache/hbase/pull/2323#discussion_r480220638



##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin1.java
##########
@@ -1492,4 +1487,16 @@ public void testMergeRegions() throws Exception {
       this.admin.deleteTable(tableName);
     }
   }
+
+  @Test (timeout=30000)
+  public void testTableNotFoundException() throws Exception {
+    ZooKeeperWatcher zkw = HBaseTestingUtility.getZooKeeperWatcher(TEST_UTIL);

Review comment:
       connection leak, needs to be closed.
   
   Instead use the non-static version TEST_UTIL.getZookeeperWatcher()... that is automatically closed with HTU teardown.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org