You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/10/27 13:54:47 UTC
[GitHub] [superset] volhahedranovich opened a new issue #17248: Series limit doesn't work in time-series chart
volhahedranovich opened a new issue #17248:
URL: https://github.com/apache/superset/issues/17248
A clear and concise description of what the bug is.
#### How to reproduce the bug
1. Go to 'Explore'
2. Select Time-series bar chart or area chart (probably others fit as well)
3. Select Metrics (in my case for ClickHouse query it is uniq(user_id))
4. Select Group by some column with high cardinality.
5. Select Series limit (5 or 10).
6. Chart doesn't change comparing with not selected Series limit. The query also doesn't change.
### Expected results
I expect to see only top 5 or 10 values of the dimension selected in Group by.
### Actual results
I see all the values, but not limited to 5 or 10.
#### Screenshots
### Environment
- browser: Chromium Version 95.0.4638.54 (Official Build) snap (64-bit)
- superset version: 1.3.1
- python version: No access
- node.js version: No access
- any feature flags active: No access
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version of superset.
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
Moreover, sort descending doesn't work properly as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido closed issue #17248: Series limit doesn't work in time-series chart
Posted by GitBox <gi...@apache.org>.
geido closed issue #17248:
URL: https://github.com/apache/superset/issues/17248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on issue #17248: Series limit doesn't work in time-series chart
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #17248:
URL: https://github.com/apache/superset/issues/17248#issuecomment-954451996
@volhahedranovich I believe this is caused by the fact that the clickhouse spec has defined `time_groupby_inline = False`: https://github.com/apache/superset/blob/9ef9adfd781cc15f3af48b1d0a366e5a891ab0f7/superset/db_engine_specs/clickhouse.py#L42 , and this is based on this the series limit isn't applied for engines that have it disabled (link to 1.3 branch): https://github.com/apache/superset/blob/286ba5d37d4e240d01bbefd2307a816829cf512d/superset/connectors/sqla/models.py#L1293-L1299. However, this behavior has since been changed on master branch, and might now work better. Would you be able to test if series limits work on master branch for Clickhouse, and if not, see if removing that line in the clickhouse spec helps? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on issue #17248: Series limit doesn't work in time-series chart
Posted by GitBox <gi...@apache.org>.
geido commented on issue #17248:
URL: https://github.com/apache/superset/issues/17248#issuecomment-1021291561
Hello @volhahedranovich I am closing this issue as we haven't heard from you in a little while. Let me know if any additional assistance is required. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido closed issue #17248: Series limit doesn't work in time-series chart
Posted by GitBox <gi...@apache.org>.
geido closed issue #17248:
URL: https://github.com/apache/superset/issues/17248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on issue #17248: Series limit doesn't work in time-series chart
Posted by GitBox <gi...@apache.org>.
geido commented on issue #17248:
URL: https://github.com/apache/superset/issues/17248#issuecomment-1021291561
Hello @volhahedranovich I am closing this issue as we haven't heard from you in a little while. Let me know if any additional assistance is required. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org