You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/02/18 13:33:47 UTC

[GitHub] [cloudstack] GutoVeronezi opened a new pull request #4703: Improve logs on processrunner

GutoVeronezi opened a new pull request #4703:
URL: https://github.com/apache/cloudstack/pull/4703


   ### Description
   This PR intends to improve logging in the class `ProcessRunner` to facilitate troubleshooting.
   
   ### Types of changes
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functioanlity)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   - [ ] Major
   - [x] Minor
   
   ### How Has This Been Tested?
   It has been tested locally on a test lab.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4703: Improve logs on ProcessRunner

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4703:
URL: https://github.com/apache/cloudstack/pull/4703#issuecomment-842394255


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 46


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GutoVeronezi commented on pull request #4703: Improve logs on ProcessRunner

Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4703:
URL: https://github.com/apache/cloudstack/pull/4703#issuecomment-842374553


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GutoVeronezi commented on pull request #4703: Improve logs on ProcessRunner

Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4703:
URL: https://github.com/apache/cloudstack/pull/4703#issuecomment-855906898


   @GabrielBrascher @DaanHoogland @sureshanaparti is there anything else to do?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GutoVeronezi commented on pull request #4703: Improve logs on ProcessRunner

Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4703:
URL: https://github.com/apache/cloudstack/pull/4703#issuecomment-836746935


   @GabrielBrascher @DaanHoogland @sureshanaparti is there anything else to do?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4703: Improve logs on ProcessRunner

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4703:
URL: https://github.com/apache/cloudstack/pull/4703#issuecomment-842375206






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #4703: Improve logs on ProcessRunner

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4703:
URL: https://github.com/apache/cloudstack/pull/4703#issuecomment-854640982


   > @sureshanaparti they are not consistent in this pr, so i'm not to worried, but i'll give them one last spin.
   
   ok @DaanHoogland 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GutoVeronezi commented on pull request #4703: Improve logs on ProcessRunner

Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4703:
URL: https://github.com/apache/cloudstack/pull/4703#issuecomment-847035509


   @GabrielBrascher @DaanHoogland @sureshanaparti is there anything else to do?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4703: Improve logs on ProcessRunner

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4703:
URL: https://github.com/apache/cloudstack/pull/4703#issuecomment-854937688


   <b>Trillian test result (tid-860)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 33666 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4703-t860-kvm-centos7.zip
   Smoke tests completed. 88 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4703: Improve logs on ProcessRunner

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4703:
URL: https://github.com/apache/cloudstack/pull/4703#issuecomment-831184602


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_multiplication_x: debian. SL-JID 508


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland merged pull request #4703: Improve logs on ProcessRunner

Posted by GitBox <gi...@apache.org>.
DaanHoogland merged pull request #4703:
URL: https://github.com/apache/cloudstack/pull/4703


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #4703: Improve logs on ProcessRunner

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4703:
URL: https://github.com/apache/cloudstack/pull/4703#issuecomment-847738713


   doesn't look like more is needed to me. @sureshanaparti, @borisstoyanov , @vladimirpetrov  do you agree those test results look good?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4703: Improve logs on ProcessRunner

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #4703:
URL: https://github.com/apache/cloudstack/pull/4703#discussion_r580860715



##########
File path: utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java
##########
@@ -34,6 +34,7 @@
 import java.util.concurrent.Future;
 import java.util.concurrent.TimeUnit;
 import java.util.concurrent.TimeoutException;
+import org.apache.commons.lang3.StringUtils;

Review comment:
       thois is bad




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4703: Improve logs on ProcessRunner

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #4703:
URL: https://github.com/apache/cloudstack/pull/4703#discussion_r578487490



##########
File path: utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java
##########
@@ -34,6 +34,7 @@
 import java.util.concurrent.Future;
 import java.util.concurrent.TimeUnit;
 import java.util.concurrent.TimeoutException;
+import org.apache.commons.lang3.StringUtils;

Review comment:
       please refer com.cloud.utils.StringUtils, and add a proxy method there if you need one.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4703: Improve logs on ProcessRunner

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4703:
URL: https://github.com/apache/cloudstack/pull/4703#issuecomment-831622661


   <b>Trillian test result (tid-594)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 45565 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4703-t594-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
   Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py
   Intermittent failure detected: /marvin/tests/smoke/test_async_job.py
   Intermittent failure detected: /marvin/tests/smoke/test_iso.py
   Intermittent failure detected: /marvin/tests/smoke/test_metrics_api.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 84 look OK, 4 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestAccounts>:setup | `Error` | 0.00 | test_accounts.py
   ContextSuite context=TestAddVmToSubDomain>:setup | `Error` | 0.00 | test_accounts.py
   test_DeleteDomain | `Error` | 0.83 | test_accounts.py
   test_forceDeleteDomain | `Failure` | 0.83 | test_accounts.py
   ContextSuite context=TestRemoveUserFromAccount>:setup | `Error` | 5.04 | test_accounts.py
   ContextSuite context=TestTemplateHierarchy>:setup | `Error` | 6.20 | test_accounts.py
   ContextSuite context=TestDeployVmWithAffinityGroup>:setup | `Error` | 0.00 | test_affinity_groups_projects.py
   test_query_async_job_result | `Error` | 0.00 | test_async_job.py
   test_01_create_iso_with_checksum_sha1 | `Error` | 65.40 | test_iso.py
   test_02_create_iso_with_checksum_sha256 | `Error` | 65.34 | test_iso.py
   test_03_create_iso_with_checksum_md5 | `Error` | 65.37 | test_iso.py
   test_04_create_iso_with_no_checksum | `Error` | 65.36 | test_iso.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GutoVeronezi commented on a change in pull request #4703: Improve logs on ProcessRunner

Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on a change in pull request #4703:
URL: https://github.com/apache/cloudstack/pull/4703#discussion_r580485951



##########
File path: utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java
##########
@@ -34,6 +34,7 @@
 import java.util.concurrent.Future;
 import java.util.concurrent.TimeUnit;
 import java.util.concurrent.TimeoutException;
+import org.apache.commons.lang3.StringUtils;

Review comment:
       @DaanHoogland as discussed in the review https://github.com/apache/cloudstack/pull/4702#pullrequestreview-593280595, it will not be done.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4703: Improve logs on ProcessRunner

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4703:
URL: https://github.com/apache/cloudstack/pull/4703#issuecomment-854501551


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 164


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4703: Improve logs on ProcessRunner

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4703:
URL: https://github.com/apache/cloudstack/pull/4703#issuecomment-831622661


   <b>Trillian test result (tid-594)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 45565 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4703-t594-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
   Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py
   Intermittent failure detected: /marvin/tests/smoke/test_async_job.py
   Intermittent failure detected: /marvin/tests/smoke/test_iso.py
   Intermittent failure detected: /marvin/tests/smoke/test_metrics_api.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 84 look OK, 4 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestAccounts>:setup | `Error` | 0.00 | test_accounts.py
   ContextSuite context=TestAddVmToSubDomain>:setup | `Error` | 0.00 | test_accounts.py
   test_DeleteDomain | `Error` | 0.83 | test_accounts.py
   test_forceDeleteDomain | `Failure` | 0.83 | test_accounts.py
   ContextSuite context=TestRemoveUserFromAccount>:setup | `Error` | 5.04 | test_accounts.py
   ContextSuite context=TestTemplateHierarchy>:setup | `Error` | 6.20 | test_accounts.py
   ContextSuite context=TestDeployVmWithAffinityGroup>:setup | `Error` | 0.00 | test_affinity_groups_projects.py
   test_query_async_job_result | `Error` | 0.00 | test_async_job.py
   test_01_create_iso_with_checksum_sha1 | `Error` | 65.40 | test_iso.py
   test_02_create_iso_with_checksum_sha256 | `Error` | 65.34 | test_iso.py
   test_03_create_iso_with_checksum_md5 | `Error` | 65.37 | test_iso.py
   test_04_create_iso_with_no_checksum | `Error` | 65.36 | test_iso.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #4703: Improve logs on ProcessRunner

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4703:
URL: https://github.com/apache/cloudstack/pull/4703#issuecomment-847868501


   > doesn't look like more is needed to me. @sureshanaparti, @borisstoyanov , @vladimirpetrov do you agree those test results look good?
   
   @DaanHoogland @GutoVeronezi are these test failures consistent across other PRs or you see only in this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4703: Improve logs on ProcessRunner

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4703:
URL: https://github.com/apache/cloudstack/pull/4703#issuecomment-839298274


   <b>Trillian test result (tid-653)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 60049 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4703-t653-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_network.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 86 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 3608.64 | test_kubernetes_clusters.py
   test_02_deploy_and_upgrade_kubernetes_cluster | `Failure` | 3603.91 | test_kubernetes_clusters.py
   test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 0.06 | test_kubernetes_clusters.py
   test_04_basic_lifecycle_kubernetes_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
   test_05_delete_kubernetes_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
   test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
   test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.07 | test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 40.20 | test_kubernetes_clusters.py
   test_disable_oobm_ha_state_ineligible | `Error` | 1512.34 | test_hostha_kvm.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4703: Improve logs on ProcessRunner

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4703:
URL: https://github.com/apache/cloudstack/pull/4703#issuecomment-842375206


   @GutoVeronezi a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4703: Improve logs on ProcessRunner

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4703:
URL: https://github.com/apache/cloudstack/pull/4703#issuecomment-837489223


   <b>Trillian test result (tid-628)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 53050 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4703-t628-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 85 look OK, 3 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 306.20 | test_routers_network_ops.py
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 307.22 | test_routers_network_ops.py
   test_01_service_offering_cpu_limit_use | `Error` | 811.32 | test_service_offerings.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 493.36 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 462.69 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 487.52 | test_vpc_redundant.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4703: Improve logs on ProcessRunner

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4703:
URL: https://github.com/apache/cloudstack/pull/4703#issuecomment-837266812


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_multiplication_x: debian. SL-JID 567


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GutoVeronezi commented on pull request #4703: Improve logs on ProcessRunner

Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4703:
URL: https://github.com/apache/cloudstack/pull/4703#issuecomment-842374553


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #4703: Improve logs on ProcessRunner

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4703:
URL: https://github.com/apache/cloudstack/pull/4703#issuecomment-854485548


   @sureshanaparti they are not consistent in this pr, so i'm not to worried, but i'll give them one last spin.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org