Re: [1/2] git commit: [flex-asjs] [refs/heads/develop] - - Fix not working numElements - Fix failing internalChildren function when element is undefined

[Alex Harui <ah...@adobe.com>]

Hi Piotr,

Did we ever figure out how internalChildren got called so early that
element was undefined?

-Alex

On 2/9/17, 10:56 AM, "Alex Harui" <ah...@adobe.com> wrote:

>
>
>On 2/9/17, 8:38 AM, "piotrz" <pi...@gmail.com> wrote:
>
>>Hi Alex,
>>
>>I think the reason that we haven't had problems with numElements is that
>>no
>>one use it before. It's true that compiler should catch it even without
>>using, but it didn't.
>>
>>As for the internalChildren - Sankar in his application did find one
>>scenario with Tabs component where our element was undefined.
>
>Do you have time to figure out why element is undefined?  Adding defensive
>code doesn't scale.  Eventually it adds up to something.  So if 99% of the
>time the defensive code doesn't do anything we want to understand what it
>would take to make it 100% so we can remove that code.
>
>Thanks,
>-Alex
>

Re: [1/2] git commit: [flex-asjs] [refs/heads/develop] - - Fix not working numElements - Fix failing internalChildren function when element is undefined

[Alex Harui <ah...@adobe.com>]

Let's wait a fees days to see if Santanu will see this and can provide the
test case.  Or at least, the stack trace.

-Alex

On 4/17/17, 11:56 PM, "piotrz" <pi...@gmail.com> wrote:

>Alex,
>
>Well I have to admit that I didn't find reason. Not sure if I found the
>time
>to dig into that. I can create some example which allows me reproduce it
>if
>my memory back on this one.
>
>Piotr
>
>
>
>-----
>Apache Flex PMC
>piotrzarzycki21@gmail.com
>--
>View this message in context:
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-fle
>x-development.2333347.n4.nabble.com%2FRe-1-2-git-commit-flex-asjs-refs-hea
>ds-develop-Fix-not-working-numElements-Fix-failing-internalChildd-tp59183p
>61178.html&data=02%7C01%7C%7C9d85beeddd1a476f971b08d486298982%7Cfa7b1b5a7b
>34438794aed2c178decee1%7C0%7C0%7C636280960340264359&sdata=3fsuaXPUtT1A8v72
>Xak%2FS%2BQfk89aBx63o7UMrUeuTaY%3D&reserved=0
>Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: [1/2] git commit: [flex-asjs] [refs/heads/develop] - - Fix not working numElements - Fix failing internalChildren function when element is undefined

[piotrz <pi...@gmail.com>]

Alex,

Well I have to admit that I didn't find reason. Not sure if I found the time
to dig into that. I can create some example which allows me reproduce it if
my memory back on this one.

Piotr



-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Re-1-2-git-commit-flex-asjs-refs-heads-develop-Fix-not-working-numElements-Fix-failing-internalChildd-tp59183p61178.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.