You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@celeborn.apache.org by "waitinfuture (via GitHub)" <gi...@apache.org> on 2023/04/02 01:55:17 UTC

[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1399: [CELEBORN-487][PERF] ShuffleClientSide support blacklist to avoid client side timeout in same worker multiple times

waitinfuture commented on code in PR #1399:
URL: https://github.com/apache/incubator-celeborn/pull/1399#discussion_r1155225227


##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -1504,6 +1505,14 @@ object CelebornConf extends Logging {
       .booleanConf
       .createWithDefault(false)
 
+  val SHUFFLE_CLIENT_BLACKLIST_ENABLED: ConfigEntry[Boolean] =
+    buildConf("celeborn.shuffle.client.blacklist.enable")

Review Comment:
   LGTM



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org