You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/03/19 22:27:38 UTC
[kudu-CR] [thirdparty] python3 is good for building LLVM
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15504
Change subject: [thirdparty] python3 is good for building LLVM
......................................................................
[thirdparty] python3 is good for building LLVM
With python2 deprecation, contemporary OS provide python3 as the default
choice: use it to build LLVM instead of building python2 in thirdparty.
Change-Id: Ib9e01da29595af5d1d7ed78e1794325df2dacf55
---
M thirdparty/build-definitions.sh
M thirdparty/vars.sh
2 files changed, 9 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/15504/1
--
To view, visit http://gerrit.cloudera.org:8080/15504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib9e01da29595af5d1d7ed78e1794325df2dacf55
Gerrit-Change-Number: 15504
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [thirdparty] python3 is good for building LLVM
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15504 )
Change subject: [thirdparty] python3 is good for building LLVM
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15504/4/thirdparty/vars.sh
File thirdparty/vars.sh:
http://gerrit.cloudera.org:8080/#/c/15504/4/thirdparty/vars.sh@154
PS4, Line 154: scirpt
nit: script
--
To view, visit http://gerrit.cloudera.org:8080/15504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9e01da29595af5d1d7ed78e1794325df2dacf55
Gerrit-Change-Number: 15504
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 20 Mar 2020 00:54:42 +0000
Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] python3 is good for building LLVM
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15504 )
Change subject: [thirdparty] python3 is good for building LLVM
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15504/5/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:
http://gerrit.cloudera.org:8080/#/c/15504/5/thirdparty/build-definitions.sh@163
PS5, Line 163: elif [[ $(python2 -V 2>&1) =~ "Python 2.7." ]]; then
You want to prefer a 'python2' (e.g. 2.7.x) binary over a 'python' (e.g. 3.x) binary?
--
To view, visit http://gerrit.cloudera.org:8080/15504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9e01da29595af5d1d7ed78e1794325df2dacf55
Gerrit-Change-Number: 15504
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 20 Mar 2020 04:02:25 +0000
Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] python3 is good for building LLVM
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15504
to look at the new patch set (#6).
Change subject: [thirdparty] python3 is good for building LLVM
......................................................................
[thirdparty] python3 is good for building LLVM
With python2 deprecation, contemporary OS provide python3 as the default
choice: use it to build LLVM instead of building python2 in thirdparty.
Change-Id: Ib9e01da29595af5d1d7ed78e1794325df2dacf55
---
M thirdparty/build-definitions.sh
M thirdparty/vars.sh
2 files changed, 9 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/15504/6
--
To view, visit http://gerrit.cloudera.org:8080/15504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib9e01da29595af5d1d7ed78e1794325df2dacf55
Gerrit-Change-Number: 15504
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [thirdparty] python3 is good for building LLVM
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15504
to look at the new patch set (#3).
Change subject: [thirdparty] python3 is good for building LLVM
......................................................................
[thirdparty] python3 is good for building LLVM
With python2 deprecation, contemporary OS provide python3 as the default
choice: use it to build LLVM instead of building python2 in thirdparty.
Change-Id: Ib9e01da29595af5d1d7ed78e1794325df2dacf55
---
M thirdparty/build-definitions.sh
M thirdparty/vars.sh
2 files changed, 10 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/15504/3
--
To view, visit http://gerrit.cloudera.org:8080/15504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib9e01da29595af5d1d7ed78e1794325df2dacf55
Gerrit-Change-Number: 15504
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [thirdparty] python3 is good for building LLVM
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15504 )
Change subject: [thirdparty] python3 is good for building LLVM
......................................................................
[thirdparty] python3 is good for building LLVM
With python2 deprecation, contemporary OS provide python3 as the default
choice: use it to build LLVM instead of building python2 in thirdparty.
Change-Id: Ib9e01da29595af5d1d7ed78e1794325df2dacf55
Reviewed-on: http://gerrit.cloudera.org:8080/15504
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M thirdparty/build-definitions.sh
M thirdparty/vars.sh
2 files changed, 9 insertions(+), 5 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/15504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib9e01da29595af5d1d7ed78e1794325df2dacf55
Gerrit-Change-Number: 15504
Gerrit-PatchSet: 7
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [thirdparty] python3 is good for building LLVM
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [thirdparty] python3 is good for building LLVM
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/15504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ib9e01da29595af5d1d7ed78e1794325df2dacf55
Gerrit-Change-Number: 15504
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [thirdparty] python3 is good for building LLVM
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15504 )
Change subject: [thirdparty] python3 is good for building LLVM
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15504/5/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:
http://gerrit.cloudera.org:8080/#/c/15504/5/thirdparty/build-definitions.sh@163
PS5, Line 163: elif [[ $(python2 -V 2>&1) =~ "Python 2.7." ]]; then
> You want to prefer a 'python2' (e.g. 2.7.x) binary over a 'python' (e.g. 3.
Good catch. Generally, it doesn't matter, but I agree that for consistency it's better to prefer python3.
--
To view, visit http://gerrit.cloudera.org:8080/15504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9e01da29595af5d1d7ed78e1794325df2dacf55
Gerrit-Change-Number: 15504
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 20 Mar 2020 04:14:52 +0000
Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] python3 is good for building LLVM
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15504
to look at the new patch set (#2).
Change subject: [thirdparty] python3 is good for building LLVM
......................................................................
[thirdparty] python3 is good for building LLVM
With python2 deprecation, contemporary OS provide python3 as the default
choice: use it to build LLVM instead of building python2 in thirdparty.
Change-Id: Ib9e01da29595af5d1d7ed78e1794325df2dacf55
---
M thirdparty/build-definitions.sh
M thirdparty/vars.sh
2 files changed, 9 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/15504/2
--
To view, visit http://gerrit.cloudera.org:8080/15504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib9e01da29595af5d1d7ed78e1794325df2dacf55
Gerrit-Change-Number: 15504
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [thirdparty] python3 is good for building LLVM
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15504 )
Change subject: [thirdparty] python3 is good for building LLVM
......................................................................
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/15504/3/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:
http://gerrit.cloudera.org:8080/#/c/15504/3/thirdparty/build-definitions.sh@160
PS3, Line 160: local python_ver_str="$(python3 -V 2>&1)"
Is python 3 installed on all the OSs we support? Including Centos 6?
http://gerrit.cloudera.org:8080/#/c/15504/3/thirdparty/build-definitions.sh@164
PS3, Line 164: elif [[ $python_ver_str =~ "Python 2.7." ]]; then
Are python 2 versions possible given you call `python3`?
http://gerrit.cloudera.org:8080/#/c/15504/3/thirdparty/vars.sh
File thirdparty/vars.sh:
http://gerrit.cloudera.org:8080/#/c/15504/3/thirdparty/vars.sh@156
PS3, Line 156: PYTHON_VERSION=2.7.13
Should we put python 3 in thirdparty or remove this all together?
--
To view, visit http://gerrit.cloudera.org:8080/15504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9e01da29595af5d1d7ed78e1794325df2dacf55
Gerrit-Change-Number: 15504
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 19 Mar 2020 23:53:46 +0000
Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] python3 is good for building LLVM
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15504 )
Change subject: [thirdparty] python3 is good for building LLVM
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9e01da29595af5d1d7ed78e1794325df2dacf55
Gerrit-Change-Number: 15504
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 20 Mar 2020 04:43:18 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] python3 is good for building LLVM
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15504
to look at the new patch set (#5).
Change subject: [thirdparty] python3 is good for building LLVM
......................................................................
[thirdparty] python3 is good for building LLVM
With python2 deprecation, contemporary OS provide python3 as the default
choice: use it to build LLVM instead of building python2 in thirdparty.
Change-Id: Ib9e01da29595af5d1d7ed78e1794325df2dacf55
---
M thirdparty/build-definitions.sh
M thirdparty/vars.sh
2 files changed, 9 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/15504/5
--
To view, visit http://gerrit.cloudera.org:8080/15504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib9e01da29595af5d1d7ed78e1794325df2dacf55
Gerrit-Change-Number: 15504
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [thirdparty] python3 is good for building LLVM
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15504
to look at the new patch set (#4).
Change subject: [thirdparty] python3 is good for building LLVM
......................................................................
[thirdparty] python3 is good for building LLVM
With python2 deprecation, contemporary OS provide python3 as the default
choice: use it to build LLVM instead of building python2 in thirdparty.
Change-Id: Ib9e01da29595af5d1d7ed78e1794325df2dacf55
---
M thirdparty/build-definitions.sh
M thirdparty/vars.sh
2 files changed, 9 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/15504/4
--
To view, visit http://gerrit.cloudera.org:8080/15504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib9e01da29595af5d1d7ed78e1794325df2dacf55
Gerrit-Change-Number: 15504
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [thirdparty] python3 is good for building LLVM
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15504 )
Change subject: [thirdparty] python3 is good for building LLVM
......................................................................
Patch Set 5: Verified+1
unrelated failures in isolate:
failed to download task files: WARNING 161 isolateserver(1484): Adding unknown file 88392d03eff
failed to download task files: WARNING 122 isolateserver(1484): Adding unknown file 56b811baf7a
--
To view, visit http://gerrit.cloudera.org:8080/15504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9e01da29595af5d1d7ed78e1794325df2dacf55
Gerrit-Change-Number: 15504
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 20 Mar 2020 03:22:26 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] python3 is good for building LLVM
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15504 )
Change subject: [thirdparty] python3 is good for building LLVM
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/15504/3/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:
http://gerrit.cloudera.org:8080/#/c/15504/3/thirdparty/build-definitions.sh@160
PS3, Line 160: local python_ver_str="$(python3 -V 2>&1)"
> Is python 3 installed on all the OSs we support? Including Centos 6?
whoops, that's a bug -- I overdid optimizing it.
Returning back to PS2.
http://gerrit.cloudera.org:8080/#/c/15504/3/thirdparty/vars.sh
File thirdparty/vars.sh:
http://gerrit.cloudera.org:8080/#/c/15504/3/thirdparty/vars.sh@156
PS3, Line 156: PYTHON_VERSION=2.7.13
> Should we put python 3 in thirdparty or remove this all together?
By default, python is not included into CentOS 8.1 minimal installation. So, I'm hesitant to remove it because kudu thirdparty build would break in that case.
I'm not sure we want to build python3 as part of thirdparty -- it's heavier and takes more time to compile.
--
To view, visit http://gerrit.cloudera.org:8080/15504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9e01da29595af5d1d7ed78e1794325df2dacf55
Gerrit-Change-Number: 15504
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 20 Mar 2020 00:47:26 +0000
Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] python3 is good for building LLVM
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15504 )
Change subject: [thirdparty] python3 is good for building LLVM
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/15504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9e01da29595af5d1d7ed78e1794325df2dacf55
Gerrit-Change-Number: 15504
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 20 Mar 2020 02:27:14 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] python3 is good for building LLVM
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15504 )
Change subject: [thirdparty] python3 is good for building LLVM
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15504/4/thirdparty/vars.sh
File thirdparty/vars.sh:
http://gerrit.cloudera.org:8080/#/c/15504/4/thirdparty/vars.sh@154
PS4, Line 154: scirpt
> nit: script
Done
--
To view, visit http://gerrit.cloudera.org:8080/15504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9e01da29595af5d1d7ed78e1794325df2dacf55
Gerrit-Change-Number: 15504
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 20 Mar 2020 01:09:25 +0000
Gerrit-HasComments: Yes