You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Chetan Mehrotra (JIRA)" <ji...@apache.org> on 2014/09/10 10:38:29 UTC

[jira] [Comment Edited] (OAK-2087) Record time when checpoint is created in SegmentNodeStore

    [ https://issues.apache.org/jira/browse/OAK-2087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14128167#comment-14128167 ] 

Chetan Mehrotra edited comment on OAK-2087 at 9/10/14 8:38 AM:
---------------------------------------------------------------

bq.  add metadata (like a simple String) to the checkpoint that the creator of the checkpoint can set. That way we could differentiate between CPs created by backup, indexer, etc if we need that.

Yes that would be helpful later however that would require an API change as current api does not capture any _checkpoint commit message_. Somay be we change the checkpoint api to taken an optional comment. Opened OAK-2089 to track that


was (Author: chetanm):
bq.  add metadata (like a simple String) to the checkpoint that the creator of the checkpoint can set. That way we could differentiate between CPs created by backup, indexer, etc if we need that.

Yes that would be helpful later however that would require an API change as current api does not capture any _checkpoint commit message_. Somay be we change the checkpoint api to taken an optional comment

> Record time when checpoint is created in SegmentNodeStore
> ---------------------------------------------------------
>
>                 Key: OAK-2087
>                 URL: https://issues.apache.org/jira/browse/OAK-2087
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: segmentmk
>            Reporter: Chetan Mehrotra
>            Assignee: Chetan Mehrotra
>            Priority: Minor
>             Fix For: 1.1
>
>         Attachments: OAK-2087.patch
>
>
> Currently SegmentNodeStore stores the end time with the checkpoint data. It would be helpful to also store the time when checkpoint was created. 
> For example AsyncIndexUpdate creates a checkpoint before indexing. It can be safely assumed that repository state before the time when that checkpoint was created is indexed (giev and take some delta say a minute). 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)