You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/03/14 19:42:33 UTC

[jira] [Commented] (CB-10866) Copy engine info for plugins into package.json

    [ https://issues.apache.org/jira/browse/CB-10866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15193865#comment-15193865 ] 

ASF GitHub Bot commented on CB-10866:
-------------------------------------

GitHub user riknoll opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/155

    CB-10866: Adding engine requirements to package.json

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-plugin-inappbrowser CB-10866

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/155.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #155
    
----
commit 786527852c59fee5c039c0114706b711baf58c9a
Author: Richard Knoll <ri...@gmail.com>
Date:   2016-03-14T18:41:10Z

    CB-10866: Adding engine requirements to package.json

----


> Copy engine info for plugins into package.json
> ----------------------------------------------
>
>                 Key: CB-10866
>                 URL: https://issues.apache.org/jira/browse/CB-10866
>             Project: Apache Cordova
>          Issue Type: Task
>          Components: Plugin InAppBrowser, Plugin SplashScreen, Plugin Statusbar, Plugin Whitelist
>            Reporter: Richard B Knoll
>            Assignee: Richard B Knoll
>              Labels: triaged
>
> Moving engine info over now that the cordova-lib plugin version selection code is merged in. I did a brief check to make sure that we didn't need to add any other engine entries and it seems like we are all good. All of the plugins build with cordova-android 3.7.X + and cordova-ios 3.9.X +. However, a lot of the cordova-ios mobilespec tests were failing. Testing each plugin is outside the scope of this task.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org