You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/03/09 23:11:07 UTC
[GitHub] [zookeeper] sushantmane opened a new pull request #1284:
ZOOKEEPER-3755: Use maven to create fatjar
sushantmane opened a new pull request #1284: ZOOKEEPER-3755: Use maven to create fatjar
URL: https://github.com/apache/zookeeper/pull/1284
- replace ant build.xml with maven pom.xml for zookeeper-contrib-fatjar module
- use maven project structure for the zookeeper-contrib-fatjar module
- create maven profile "fatjar" to build a fatjar file.
- update readme files
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] sushantmane commented on a change in pull request
#1284: ZOOKEEPER-3755: Use maven to create fatjar
Posted by GitBox <gi...@apache.org>.
sushantmane commented on a change in pull request #1284: ZOOKEEPER-3755: Use maven to create fatjar
URL: https://github.com/apache/zookeeper/pull/1284#discussion_r395495555
##########
File path: zookeeper-it/pom.xml
##########
@@ -0,0 +1,77 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+ <!--
+ /**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+ -->
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.zookeeper</groupId>
+ <artifactId>parent</artifactId>
+ <version>3.7.0-SNAPSHOT</version>
Review comment:
Done. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] eolivelli closed pull request #1284: ZOOKEEPER-3755:
Use maven to create fatjar
Posted by GitBox <gi...@apache.org>.
eolivelli closed pull request #1284: ZOOKEEPER-3755: Use maven to create fatjar
URL: https://github.com/apache/zookeeper/pull/1284
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] eolivelli commented on issue #1284: ZOOKEEPER-3755: Use
maven to create fatjar
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #1284: ZOOKEEPER-3755: Use maven to create fatjar
URL: https://github.com/apache/zookeeper/pull/1284#issuecomment-604693890
thank you @sushantmane !
Committed to master and to 3.6.
This feature will be delivered with 3.6.1, hopefully next week.
@breed please take a look during the release process in order to check that the results are what you are expecting
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] sushantmane commented on issue #1284: ZOOKEEPER-3755:
Use maven to create fatjar
Posted by GitBox <gi...@apache.org>.
sushantmane commented on issue #1284: ZOOKEEPER-3755: Use maven to create fatjar
URL: https://github.com/apache/zookeeper/pull/1284#issuecomment-601588872
@eolivelli @maoling : Could you please review this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] sushantmane commented on a change in pull request
#1284: ZOOKEEPER-3755: Use maven to create fatjar
Posted by GitBox <gi...@apache.org>.
sushantmane commented on a change in pull request #1284: ZOOKEEPER-3755: Use maven to create fatjar
URL: https://github.com/apache/zookeeper/pull/1284#discussion_r395509578
##########
File path: pom.xml
##########
@@ -31,7 +31,7 @@
<artifactId>parent</artifactId>
<packaging>pom</packaging>
<!-- to change version: mvn -\-batch-mode release:update-versions -DdevelopmentVersion=3.6.0-SNAPSHOT -->
- <version>3.7.0-SNAPSHOT</version>
+ <version>${revision}</version>
Review comment:
I've updated the patch. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] breed commented on issue #1284: ZOOKEEPER-3755: Use
maven to create fatjar
Posted by GitBox <gi...@apache.org>.
breed commented on issue #1284: ZOOKEEPER-3755: Use maven to create fatjar
URL: https://github.com/apache/zookeeper/pull/1284#issuecomment-604170066
+1 anyone want to commit this? (i can do it on friday.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] maoling commented on issue #1284: ZOOKEEPER-3755: Use
maven to create fatjar
Posted by GitBox <gi...@apache.org>.
maoling commented on issue #1284: ZOOKEEPER-3755: Use maven to create fatjar
URL: https://github.com/apache/zookeeper/pull/1284#issuecomment-599843188
- @sushantmane The CI [failure](https://travis-ci.org/github/apache/zookeeper/jobs/660395396?utm_medium=notification&utm_source=github_status) is related ?
- Cc: @eolivelli PTAL :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] sushantmane commented on issue #1284: ZOOKEEPER-3755:
Use maven to create fatjar
Posted by GitBox <gi...@apache.org>.
sushantmane commented on issue #1284: ZOOKEEPER-3755: Use maven to create fatjar
URL: https://github.com/apache/zookeeper/pull/1284#issuecomment-600005864
@maoling Yeah, there are some spotbugs check failures in the zookeeper-it module. I'll fix those and update the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] sushantmane commented on a change in pull request
#1284: ZOOKEEPER-3755: Use maven to create fatjar
Posted by GitBox <gi...@apache.org>.
sushantmane commented on a change in pull request #1284: ZOOKEEPER-3755: Use maven to create fatjar
URL: https://github.com/apache/zookeeper/pull/1284#discussion_r395504286
##########
File path: pom.xml
##########
@@ -31,7 +31,7 @@
<artifactId>parent</artifactId>
<packaging>pom</packaging>
<!-- to change version: mvn -\-batch-mode release:update-versions -DdevelopmentVersion=3.6.0-SNAPSHOT -->
- <version>3.7.0-SNAPSHOT</version>
+ <version>${revision}</version>
Review comment:
No it's not necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] eolivelli commented on a change in pull request #1284:
ZOOKEEPER-3755: Use maven to create fatjar
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #1284: ZOOKEEPER-3755: Use maven to create fatjar
URL: https://github.com/apache/zookeeper/pull/1284#discussion_r395500329
##########
File path: pom.xml
##########
@@ -31,7 +31,7 @@
<artifactId>parent</artifactId>
<packaging>pom</packaging>
<!-- to change version: mvn -\-batch-mode release:update-versions -DdevelopmentVersion=3.6.0-SNAPSHOT -->
- <version>3.7.0-SNAPSHOT</version>
+ <version>${revision}</version>
Review comment:
In my opinion this won't work together with the maven release plugin.
We are using it in order to automate the release process.
Is it necessary for you ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] breed commented on a change in pull request #1284:
ZOOKEEPER-3755: Use maven to create fatjar
Posted by GitBox <gi...@apache.org>.
breed commented on a change in pull request #1284: ZOOKEEPER-3755: Use maven to create fatjar
URL: https://github.com/apache/zookeeper/pull/1284#discussion_r394499519
##########
File path: zookeeper-it/pom.xml
##########
@@ -0,0 +1,77 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+ <!--
+ /**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+ -->
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.zookeeper</groupId>
+ <artifactId>parent</artifactId>
+ <version>3.7.0-SNAPSHOT</version>
Review comment:
is there a way to have one version that all sub pom.xml files pull from. it seems like this would be a pain to keep up to date.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] sushantmane commented on a change in pull request
#1284: ZOOKEEPER-3755: Use maven to create fatjar
Posted by GitBox <gi...@apache.org>.
sushantmane commented on a change in pull request #1284: ZOOKEEPER-3755: Use maven to create fatjar
URL: https://github.com/apache/zookeeper/pull/1284#discussion_r395514842
##########
File path: zookeeper-it/pom.xml
##########
@@ -0,0 +1,77 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+ <!--
+ /**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+ -->
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.zookeeper</groupId>
+ <artifactId>parent</artifactId>
+ <version>3.7.0-SNAPSHOT</version>
Review comment:
@breed
It seems the maven version plugin is used to update the version in pom files. Therefore I've reverted single version changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] sushantmane commented on issue #1284: ZOOKEEPER-3755:
Use maven to create fatjar
Posted by GitBox <gi...@apache.org>.
sushantmane commented on issue #1284: ZOOKEEPER-3755: Use maven to create fatjar
URL: https://github.com/apache/zookeeper/pull/1284#issuecomment-600271601
@maoling
Update: I'll raise separate PR to fix spotbugs and checkstyle issues in the zookeeper-it module.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services